test(nodes): CI-sized timeout for the every-angle corner-joint sweep - #693
Merged
Conversation
The sweep runs ~5.7s on a 2-core x64 CI runner — past bun's default 5s per-test budget (2-3s locally on Apple Silicon). First surfaced by private-editor's quality gate on the #692 submodule bump, the first CI to ever run this suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The `roof-corner.test.ts` full-angle sweep ("keeps the complete roof, gutter, beam, and shared-post joint continuous at every supported angle") runs ~5.7s on a 2-core x64 CI runner — past bun's default 5s per-test budget. It runs 2-3s locally on Apple Silicon, which is why it never failed a dev machine.
Surfaced by pascalorg/private-editor#381 (the #692 submodule bump) — the first CI lane to ever execute this suite (#651 merged before any test lane existed for it). Not a correctness failure: the sweep passes everywhere given time; this gives it a 30s budget.
🤖 Generated with Claude Code
Note
Low Risk
Test-only timeout bump with no production or correctness changes.
Overview
Gives the full-angle lean-to corner-joint sweep in
roof-corner.test.tsa 30s budget so it no longer times out on slower CI runners.The test itself is unchanged; bun’s default 5s per-test limit was too tight for the ~6s sweep on 2-core x64 CI (it finishes in 2–3s locally).
Reviewed by Cursor Bugbot for commit 709a937. Bugbot is set up for automated code reviews on this repo. Configure here.