Conversation
0.0.9 removes RandomMultiPair, whose insert scanned every entry sharing the key because the value did not participate in the order. Filling one key was quadratic: 356 us per insert at 16,000 values against 333 ns after. MultiPair is now OrdMultiPair, identified and ordered by its (key, value) pair. Nothing here constructs a MultiPair field by field, so the From and SizeMeasurable impls carry over unchanged and this is a dependency bump. Needed so WorkTable beta.15 can build against a published index: WorkTable depends on both crates and this one pins the index exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Middle link of the beta.15 cascade.
data_bucketpinsWorkTablesIndexexactly, so it has to move before WorkTable can build against a published index.RandomMultiPairWhy 0.0.9
RandomMultiPair::insertscanned every entry already stored under the key, because the value did not participate in the order and a stored entry could not be located by it. O(n) per insert, quadratic to fill one key.MultiPairis nowOrdMultiPair, identified and ordered by its(key, value)pair.Impact here
None beyond the bump. Nothing in this crate constructs a
MultiPairfield by field; theFrom<MultiPair<T, L>> for IndexValue<T>andSizeMeasurable/VariableSizeMeasurableimpls are generic over the alias and carry over unchanged.Tests
69 lib + 2 doc, all passing, built against WorkTablesIndex#13.