Release 0.5.6 on WorkTablesIndex 0.0.10 - #71
Merged
Conversation
WorkTable and DataBucket exchange concrete WorkTablesIndex CDC types, and both
pin that crate exactly, so the two pins are one decision. Bumping WorkTable to
0.0.10 without this resolves two versions of the same crate:
WorkTablesIndex v0.0.9 via data_bucket 0.5.5
WorkTablesIndex v0.0.10 via worktable
which are distinct Rust types even though the source is identical, and the
build fails on `IndexValue<_>: From<Pair<T, Link>> is not satisfied`. That was
reproduced, not predicted.
71 tests pass against 0.0.10 through a local path patch.
**Merge after WorkTablesIndex#14**, which is what publishes 0.0.10. Until then
this branch's CI cannot resolve its own dependency, and that failure is the
ordering rather than a defect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DataBucket half of the beta.17 release train. Nothing else changes: the
version and one pin.
Why this is not optional
WorkTable and DataBucket exchange concrete WorkTablesIndex CDC types, and both
pin that crate exactly. So the two pins are one decision, not two.
Bumping WorkTable to
0.0.10without this resolves two versions of the samecrate:
They are distinct Rust types even though the source is identical, and the
build fails:
That was reproduced by trying it, not predicted from the manifests.
Verified
71 tests pass against WorkTablesIndex 0.0.10 through a local path patch. The
patch is not committed: CI has no sibling checkouts, and a committed path
override means published users silently get different code from the one that
was tested.
Merge order
After WorkTablesIndex#14,
which is what publishes
0.0.10. Until that lands, this branch's CI cannotresolve its own dependency, and that failure is the ordering rather than a
defect in this change.
Then
worktabletakesdata_bucket 0.5.6andWorkTablesIndex 0.0.10together, which is the only combination that resolves one copy of the shared
types.
Merging publishes: master carries a new version.