Take tauri-runtime-blitz by version, so no dependency is a git source - #25
Merged
Conversation
It was the last git dependency, and the only reason it was one is that the crate could not be published: it set publish = false, it carried a [patch] redirecting usvg at a git branch, and its macos-private-api feature forwarded nothing, so --all-features left the runtime impl carrying a WindowBuilder method the trait did not declare. crates.io verifies with every feature on, so that last one failed to package for the same reason it failed to check. All three are fixed upstream and 0.1.0 is published, along with blitz-control-protocol. Cargo.lock now has no git sources at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #23.
tauri-runtime-blitzwas the last git dependency in thisrepository, and the only reason it was one is that the crate could not be
published:
publish = falsein the workspace manifest.[patch.crates-io]redirectingusvgat a DioxusLabs branch forTree::intrinsic_dimensions. The publishedps-anyrender-svgalready dependson
ps-usvg, so nothing in the graph asks for plainusvgany more and thepatch was dead weight. crates.io refuses a crate with a git dependency.
macos-private-apiwas an empty feature that forwarded nothing.tauri-runtimedeclares
WindowBuilder::transparentbehind its own feature of that name andthe runtime implements it behind the local one, so
--all-featuresturned thelocal flag on without turning on
tauri-runtime's, leaving the impl carrying amethod the trait did not declare. crates.io verifies with every feature
enabled, so this failed to package for the same reason it failed to check.
AgencyZero already works around it by hand, enabling the feature on both
dependency edges; the feature now forwards, so that is no longer necessary.
All three are fixed in pathscale/tauri-runtime-blitz@794b5d4, and
0.1.0ispublished along with
blitz-control-protocol 0.1.0.Cargo.locknow contains no git sources at all, andAGENTS.mdno longercarries an exception it does not need.
Verified
cargo test --workspace --all-features: 47 pass, 0 failcargo clippy --workspace --all-targets --all-features -- -D warnings: cleancargo fmt --all -- --check: cleangrep -c 'source = "git' Cargo.lock→0