Move the frontend to @pathscale/ui 2.11.9 and Solid 2.0.0-rc.4 - #27
Closed
pathscale wants to merge 3 commits into
Closed
Move the frontend to @pathscale/ui 2.11.9 and Solid 2.0.0-rc.4#27pathscale wants to merge 3 commits into
pathscale wants to merge 3 commits into
Conversation
added 3 commits
August 31, 2026 09:42
…0-rc.4 local-ui/package.json still asked for @pathscale/ui ^2.5.0, solid-js ^1.9.5 and solid-layouts ^0.1.3, from before the chrome was ported. Those are the peer ranges of a workspace member, so bun resolved them for the whole workspace and installed solid-js 1.9.14 and @pathscale/ui 2.5.0 -- the app has been building against Solid 1 while its own package.json asked for 2.0.0-rc.0. Widening the member's ranges is what makes the app's pins take effect. Also adds the @iconify-json sets. index.css @sources @pathscale/ui, which uses mdi-- tokens internally, and nothing installed them, so those icons resolved to nothing. babel-preset-solid moves to rc.2 behind a caret; the exact rc.0 pin could not take a fix. Verified: typecheck, biome, the 15 frontend tests, a production build, and the built chrome rendering its address bar, title bar and tabs. The scripts/solid-2-boundary.ts workaround stays. Its exit condition is solid-layouts-oxc consulting boundaryFor, which 0.2.2 now does -- but rsbuild-plugin-solid-layouts 0.2.1 carries its own 0.2.1 copy of the validator, and a bun override does not dedupe it. The pair goes when that plugin publishes against 0.2.2.
Nothing here uses daisyUI; the comment described the cascade problem in terms of a package this repository does not install.
A patch release: no exports added or removed against 2.11.9, and the same peer range. The caret already admitted it; this pins the lockfile to it.
Owner
Author
Owner
Author
|
Superseded by #33, which consolidates all chuzz work into one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resolution bug this fixes
local-ui/package.jsonstill asked for@pathscale/ui ^2.5.0,solid-js ^1.9.5andsolid-layouts ^0.1.3, from before the chrome was ported. Those are the peer ranges of a workspace member, so bun resolved them for the whole workspace and installedsolid-js@1.9.14and@pathscale/ui@2.5.0.The app has been building against Solid 1 while its own
package.jsonasked for2.0.0-rc.0. Widening the member's ranges is what makes the app's own pins take effect — with them narrow, bumping the app alone silently changes nothing, which is what happened on the first attempt here.Note
local-ui/bundle/package.jsonis generated fromlocal-ui/package.json; editing the bundle is overwritten by the nextlayouts:local.Also
@iconify-json/lucideand@iconify-json/mdi.index.css@sources@pathscale/ui, which usesmdi--tokens internally, and nothing installed them, so those icons resolved to nothing.babel-preset-solidto rc.2 behind a caret; the exact rc.0 pin could not take a fix.What deliberately stays
scripts/solid-2-boundary.tsand its alias stay. Their exit condition —solid-layouts-oxcconsultingboundaryForinstead of grepping the hardcoded Solid 1 specifier — is met in 0.2.2, and the pair does come out cleanly against it (tried, and the generated bundle emits the Solid 2 boundary on its own). Butrsbuild-plugin-solid-layouts@0.2.1carries its own 0.2.1 copy of the validator, and a bunoverridedoes not dedupe it, so the build still fails withAddressBar entry has no application compiler boundary. The pair goes when that plugin publishes against 0.2.2.Verification
typecheck,biome check, the 15 frontend tests and a production build all pass. The built chrome renders: address bar, title bar, tabs, and the@pathscale/uibuttons.Scope
Dependency and resolution only. The 16 local
@chuzz/uilayouts are genuine browser chrome (AddressBar, TabList, TitleBar, Viewport) with no@pathscale/uiequivalent, so they stay local.