fix(headless): no font stack, and revert the fontconfig install - #42
Merged
Conversation
Reverts the apt step added a moment ago. Installing libfontconfig1-dev on the runner was the wrong direction: headless means no window, no renderer stack and no fonts, and reaching for a system package is the tell that something is enabled which should not be. The real cause is here. ps-blitz took `system-fonts` out of blitz-dom's own defaults in "build: no font dependency in a headless build", and this manifest named it again in three places: blitz-dom, blitz-script and dioxus-native. So every chuzz build asked for parley's font enumeration, which on Linux is fontconfig, including the binary that opens no window and paints no glyph. `system-fonts` is now part of `gui`, next to `dep:tauri`. The window paints real glyphs and wants real faces; the headless host does not. `blitz-script?/system-fonts` with the question mark, because blitz-script is optional and rides `javascript`. Without it, enabling `gui` would drag the script engine in on its own. Verified on the Linux target: `cargo tree -i yeslogic-fontconfig-sys` reports no such package for the headless feature set, and still resolves it through parley for the default build, so the window keeps its fonts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the
libfontconfig1-devstep merged a moment ago. That was the wrong direction: headless means no window, no renderer stack and no fonts, and reaching for a system package is the tell that something is enabled which should not be.The real cause is in this manifest. ps-blitz removed
system-fontsfrom blitz-dom's defaults in86a24f8f build: no font dependency in a headless build, and chuzz named it again in three places:blitz-dom,blitz-scriptanddioxus-native. Every build therefore asked for parley's font enumeration, which on Linux is fontconfig, including the binary that opens no window and paints no glyph.system-fontsnow sits inguibesidedep:tauri.blitz-script?/system-fontstakes the question mark because blitz-script is optional and ridesjavascript.Verified on the Linux target:
cargo tree -i yeslogic-fontconfig-sysfinds no such package in the headless graph, and still resolves it via parley for the default build, so the window keeps its fonts. Both binaries build; fmt clean.No version bump: the manifest change alters only which features a build selects, and the action is consumed at
@master.