Repository navigation
Fix process channel cleanup after exit - #1
Draft
pauljccode wants to merge 1 commit into
Draft
pauljccode wants to merge 1 commit into
pauljccode wants to merge 1 commit into
Conversation
Detach exited processes before freeing them so delayed channel cleanup cannot signal a newer process through reused heap storage. Let the existing EOF exchange close drained channels, make cleanup after normal exit safe, and release the callback context on every exit path.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exited process can leave a dangling pointer in its channel. If the allocator reuses that address, closing the old channel can send
SIGINTto a newer child. The failing log shows a new child receivingSIGINTimmediately after delayed channel-close requests, consistent with this defect; allocator reuse was not captured.Detach the process in the exit callback, allow cleanup after normal exit, and free the callback context on every exit path. Remove the read-time shutdown to avoid freeing the detached channel while
channel_readstill uses it. Non-interactive channels retain read-response-before-close ordering.Verification:
post/test/cmd_execrepetitions per platform.Upstream: rapid7/mettle#298.