Repository navigation
chore(config): point SDK_URL at /sdk/hosted-fields/latest/index.js - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #170190 — the Hosted Fields browser artifacts move to a
/sdk/prefix with an immutable directory per release.Two config-only commits, 23 committed templates each: the root
.env.example, every stack's.env.exampleanddeploy/*.env.example, and the commentedenv[SDK_URL]in the PHP pool config.SDK_URLgoes from/assets/libs/hosted-fields/latest/index.jsto/sdk/hosted-fields/latest/index.js.?segment=paynettail is gone. The segment query was removed from the script URL a while back — the field now takes the deployment context path from thecpclaim of theephemeralTicket(see the SDK's Deployment contract), so the sample was showing a parameter nothing reads.lateststays the value the examples ship with — they are demos, and a version-pinned URL would need bumping on every release. Production integrations should pin the version; that recommendation belongs in the integration guide.No code change: every example already reads the URL from the environment, none hardcodes it in markup, and each app builds its CSP from the origin of
SDK_URL, so a path-only move needs no CSP edit. The e2e emulator serves its own/sdk.jsand is unaffected.