OCTO-11513: Re-emit STYLE blocks and writing direction on VTT→VTT#387
Merged
Conversation
🔴 PR Compliance ReviewRisk Level: HIGH
DO NOT MERGE - Critical issues must be fixed first Full report available in workflow artifacts |
🔴 PR Compliance ReviewRisk Level: HIGH
DO NOT MERGE - Critical issues must be fixed first Full report available in workflow artifacts |
🔴 PR Compliance ReviewRisk Level: HIGH
DO NOT MERGE - Critical issues must be fixed first Full report available in workflow artifacts |
…-style: italic) - check-last-pr skill no longer flags module splits as removed API or existing tests as missing - Changelog and version bump to 2.2.29.dev1
🟡 PR Compliance ReviewRisk Level: MEDIUM
REVIEW REQUIRED - Address issues before merging Full report available in workflow artifacts |
dianadersedan
approved these changes
Jul 13, 2026
panasicov
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::cuemarker key)vertical:rl/vertical:lrfromLayout.writing_directionwhen passthrough positioning isn't availablepycaption/webvtt.py(1200 lines) into apycaption/webvtt/package (reader, writer, constants) — public API unchangedChanges
writer.py— new_build_style_block()emits global::cuebefore class-specific rules;_convert_positioning()emits vertical settingreader.py— inserts::cuemarker in_parse_style_blocks()to signal VTT origin to the writergeometry.py—as_percentage_of()andfit_to_screen()now preservewriting_directionpycaption/webvtt.py→pycaption/webvtt/package (__init__.py,constants.py,reader.py,writer.py)writer.py — _format_css_declarations() reverse-maps internal keys (italics → font-style: italic) so STYLE blocks with font-style/font-weight/text-decoration emit valid CSS instead of internal representations like italics: True
Safety
::cuekey, so_build_style_block()returns emptyTest plan
from pycaption import WebVTTReader, WebVTTWriterstill works