OCTO-11513 #388
Merged
Merged
Conversation
…s italic/bold/underline - Emit CaptionReadWarning when multiline cue line:% extends beyond viewport - Preserve REGION blocks through VTT→VTT read/write cycle - Add regions param to CaptionSet with get/set accessors - Compact changelog for 2.2.29
🟡 PR Compliance ReviewRisk Level: MEDIUM
REVIEW REQUIRED - Address issues before merging Full report available in workflow artifacts |
lorandvarga
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::cue { font-style: italic }now wraps bare text nodes in STYLE openers/closers so downstream writers (VTT, DFXP, SCC) emit inline formatting (<i>,<span tts:fontStyle="italic">) without double-wrapping already-styled cues.CaptionReadWarningwhen a multiline cue'sline:%position would push text beyond the viewport (based on WebVTT's 15-line grid). Non-fatal — does not alter output.CaptionSet; writer re-emits them as REGION blocks soregion:idcue references remain valid in VTT→VTT conversion.regionsparameter (defaults to{}) withget_regions()/set_regions()accessors. Keyword-only in practice — no positional arg shift for existing callers.Safety
::cuestyles or regions, so new logic never triggers.WebVTTSegmentWritercreatesCaptionSet({lang: CaptionList(...)})without styles/regions — confirmed no breakage.deepcopyin writers correctly preserves the new_regionsdict.stacklevel=4on warning verified to point at the caller's.read()line.Test plan
::cue { font-style: italic }→ DFXP produces<span tts:fontStyle="italic">