Octo 11512#389
Open
OlteanuRares wants to merge 6 commits into
Open
Conversation
…h tab offsets, and italics/underline to mid-row codes. Unsupported styles silently dropped. Split pycaption/scc/ into reader.py + writer.py; fix mutable default args in base.py and remove dead code.
with chronological ordering across mixed modes. Fix vertical positioning formula to use exact inverse of reader (round((y-5)/90*15)+1), enabling lossless SCC→VTT→SCC row roundtrip. Propagate caption_mode/roll_up_rows metadata through PreCaption._INTERNAL_STYLE_KEYS filtering. WebVTTWriter injects REGION blocks for roll-up captions without clobbering existing regions. Fix merge artifact in base.py CaptionSet.__init__.
webvtt/writer.py. Extract _CUE_SELECTOR constant in WebVTTReader to eliminate repeated ::cue literals. Remove unused imports (COMMANDS, PLAIN_TEXT_COMMANDS) from scc/specialized_collections.py. Apply black formatting to all changed files on the branch.
- Double special/extended character codes (4-byte) per CEA-608 spec
- Emit MID_ROW_ITALIC_UNDERLINE when both styles active at col>0
- Multi-chunk pop-on now buffers under single ENM+RCL…EDM+EOC instead
of overwriting previous chunks
- Strip leading space after mid-row code to compensate for the implicit
visible space the code produces on screen
🔴 PR Compliance ReviewRisk Level: HIGH
DO NOT MERGE - Critical issues must be fixed first Full report available in workflow artifacts |
panasicov
previously approved these changes
Jul 16, 2026
🔴 PR Compliance ReviewRisk Level: HIGH
DO NOT MERGE - Critical issues must be fixed first Full report available in workflow artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.