Repository navigation
project release: resolve macros in _service url and revision for changelog links - #145
Merged
Merged
Conversation
Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the server packages moved their obs/service url/revision to the
PG_SOURCE_GIT* macros,
project releaserendered the CHANGELOG upstreamlink as
(%!{PG_SOURCE_GIT_URL})for percona-postgresql and the tarballs'percona-psql; the same unresolved URL fed the CVE scan. The revision was
already resolved, but with the source project's macro chain, which lacks
the major's values.
_extract_upstream_info_from_servicenow resolves both url and revisionfrom the package directory's own macro chain (a symlinked package resolves
from the link's location); an unresolvable url yields no link instead of a
macro. Verified on staging 17/18: percona-postgresql and percona-psql give
https://github.com/percona/postgres/releases/tag/PSP-, and
pg_tde's revision macro resolves as well.
644 tests, black, pyright 0 errors.