Skip to content

The Docker upgrade jobs compared versions against hand-kept tables in - #176

Merged
mohitj1988 merged 1 commit into
mainfrom
fix_expected_version_for_upgrade
Oct 20, 2026
Merged

mohitj1988 merged 1 commit into
mainfrom
fix_expected_version_for_upgrade

Conversation

@mohitj1988

Copy link
Copy Markdown
Collaborator

ppg-testing, which drift every time OBS bumps a component. They could not use EXPECTED_VERSIONS: an upgrade entry lives in a common project and tests two images from two projects, so the list computed from the entry's own project was the first major in its paths (PG 18 for the common container projects) -- wrong for a 16 -> 17 upgrade in both phases, and no single list can be right for both (percona-postgresql and percona-pgaudit differ).

_resolve_lane_images now records, before resolving, the projects the entry's image references name (_image_projects; entry-level, so it never reaches a job's parameters). For an entry with an OLD_REPOSITORY project, EXPECTED_VERSIONS is computed from the new image's project (NEW_REPOSITORY, else REPOSITORY) and the new OLD_EXPECTED_VERSIONS from OLD_REPOSITORY's, as for a server entry of each project. Values set in the entry are kept.

@mohitj1988
mohitj1988 requested a review from rjd15372 October 20, 2026 05:20
ppg-testing, which drift every time OBS bumps a component. An upgrade entry
lives in a common project and tests two images from two projects, so the
list computed from the entry's own project was the first major in its paths
(PG 18 for the common container projects) -- wrong for a 16 -> 17 upgrade
in both phases, and no single list can be right for both (percona-postgresql
and percona-pgaudit differ).

_resolve_lane_images now records, before resolving, the projects the
entry's image references name (_image_projects; entry-level, so it never
reaches a job's parameters). For an entry with an OLD_REPOSITORY project,
EXPECTED_VERSIONS is computed from the new image's project (NEW_REPOSITORY,
else REPOSITORY) and the new OLD_EXPECTED_VERSIONS from OLD_REPOSITORY's,
with the same OBS-built versions as for a server entry of each project.
They are computed before the conflict check, so a version conflict in
either image's project blocks the upgrade entry like one in the lane's own
packages. Values set in the entry are kept.
@mohitj1988
mohitj1988 force-pushed the fix_expected_version_for_upgrade branch from eebd16d to 83f3035 Compare October 20, 2026 12:33
@mohitj1988
mohitj1988 merged commit 0456f03 into main Oct 20, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants