Repository navigation
release_pr: read the PR head sha without --jq - #203
Merged
Merged
Conversation
On a synchronize push, classify looked up the PR head with `gh pr view --json headRefOid --jq .headRefOid`. gh prints a jq string result unquoted, so json.loads failed on the bare sha and the Resolve job of every push to a release PR crashed (PR #201). Read the field from the --json output instead. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every push to a release PR crashed
OBS Release PRin Resolve release PR → Classify (seen on #201, run 41059246214):The changelog-only push check (67a7f74) fetched the head with
gh pr view --json headRefOid --jq .headRefOid. gh prints a jq string result unquoted, so_gh_jsoncould not parse the bare sha. The fix reads the field from the plain--jsonoutput.Only the
synchronizepath (--since) was affected. Open/reopen andworkflow_dispatchnever reach it.Test added for the push path: it fails on the old script and passes with the fix (750 tests pass).