Repository navigation
release freeze: restore only the <build> element on unfreeze - #206
Merged
Merged
Conversation
restore_builds pushed the whole pre-freeze meta snapshot back after osc release. On isv:percona:ppg:staging:18 the snapshot still carried 11 releasetargets that OBS had rewritten to project="deleted" (left by a cancelled populate), so the restore put back what the release hop had just removed (meta rev 73 clean, rev 74 restored them). The freeze only rewrites <build>, so restore now swaps only the snapshot's <build> into the current meta (projects and packages) and keeps everything changed inside the freeze window. If the current meta cannot be read it falls back to the full snapshot so builds are never left disabled. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #205 the #201 populate went green, but production
isv:percona:ppg:staging:18still carries 11<releasetarget project="deleted" repository="deleted"/>entries. Its meta history shows why:deletedosc releasedeletedrestore_buildspushes the rev-70 snapshot back verbatimfreeze_buildsonly rewrites<build>, but the unfreeze rolled back the entire meta, resurrecting whatever stale release targets existed at freeze time (and would clobber any other meta change made inside the freeze window).Change
restore_builds/restore_packages: read the current meta and swap in only the snapshot's<build>element (none in the snapshot → the freeze's<build><disable/>is just dropped). Everything else stays as it is at restore time.docs/PERCONA_OBS_TOOL.md.The next populate after merge removes the 11
deletedtargets on staging:18 for good.Tests
<build>flags round-trippytest tests755 passed; black + pyright clean