fix: repair a link and help text damaged by the brand sweep - #4
Merged
Conversation
The example-alias sweep replaced the bare word 'play', which also hit the Go playground link in a pathMatch comment, leaving a dead mysilo.golang.org URL. The proxy-set description referred to the sibling command with template placeholder syntax that reads as noise; it now spells the command out. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor defects found by an independent review of the 0804→HEAD range.
cmd/find.go:111— the example-alias sweep replaced the bare wordplay, which also matched the Go playground link in thepathMatchcomment, leaving a deadhttps://mysilo.golang.org/p/Ega9qgD4Qz. Restored. This was the only collateral hit;git grep 'mysilo\.'overcmd/*.gonow returns nothing.cmd/support-proxy-set.go— the DESCRIPTION pointed at the sibling command as'{{.HelpName}} ..' -> 'remove', which renders as noise. Now spells outmc support proxy remove ALIAS.Verified:
go build ./...,go test ./cmd/ -count=1,check-branding.shpass; help output rendering checked on the built binary.🤖 Generated with Claude Code