feat(fork): mo hoa B01 — ha canh nhanh doi dinh danh kho + guard dinh danh fork (B2 lat cat) - #100
Draft
phanlemanh wants to merge 29 commits into
Draft
feat(fork): mo hoa B01 — ha canh nhanh doi dinh danh kho + guard dinh danh fork (B2 lat cat)#100phanlemanh wants to merge 29 commits into
phanlemanh wants to merge 29 commits into
Conversation
…desktop-release Tach khoi nhanh feat/normalize-text-vi: goi B01 nay la cong cua phien aisuite-60, lot vao ba commit cua phien normalize-text-vi do thao tac git qua rong (add -A, roi commit khong neu duong dan). LUU Y CHO NGUOI DUYET: .github/workflows/desktop-release.yml go trigger 'tags: v*'. Sau khi merge, gan tag vX.Y.Z KHONG con sinh ban cai desktop. CLAUDE.md phan Release checklist van ghi nguoc lai va CHUA duoc sua. Ly do tat tro vao ADR-0013 / research-mo-hoa-2026-08.md, hai tai lieu nam o nhanh docs/director-lane-d chu khong phai nhanh nay.
… that
Hai dau ho cua goi B01, do lan review cua nhanh feat/normalize-text-vi bat duoc.
1. Header DISARMED trong desktop-release.yml truoc do tro vao ADR-0013 va
research-mo-hoa-2026-08.md — hai file song o nhanh docs/director-lane-d, khong
co tren nhanh nay. Mot ly do khong doc duoc tu chinh cho no nam. Viet lai de
TU DUNG DUOC: neu thang co che (docker-publish.yml cung chi day anh khi co tag
v*, nen mot tag han hai duong lai voi nhau), va neu dieu kien khoi phuc.
2. CLAUDE.md muc Release checklist noi nguoc voi hanh vi moi: van ghi "Tag the
release; desktop-release.yml builds ... into a draft GitHub Release and flips
it public". Sau khi go trigger, gan tag KHONG sinh gi ca. Doi hanh vi phat
hanh ma khong sua tai lieu mo ta no la loi cua chinh goi nay.
Sua kem hai cho lech CO TRUOC goi nay, cung mot muc:
- "PyPI `tongflow` SDK" -> "PyPI `oneflow-sdk` package" (import van la tongflow),
dung ADR-0008 da ky.
- Checklist ghi workflow dung `OneFlow-*.dmg` trong khi workflow that dung
`TongFlow-*.dmg`. Ghi dung ten that va noi ro vi sao khong doi ten: workflow
nay se bi THAY THE o S5 chu khong phai rebrand.
Guard xanh tren nhanh nay: check-prefix-docs, check-manifest-doc-synced,
check-action-pins, check-workflow-drift — deu exit 0.
cf4c757 dinh tra ba README ve thuan rebrand nhung LAT ⬜ thanh ✅ thay vi XOA HAN dong do. main khong he co dong nay — no do nhanh feat/normalize-text-vi them vao khi dang ky plugin. He qua da do: hai nhanh xung dot o ca ba README, khac dung mot ky tu (⬜ vs ✅), va cach go 'giu ca hai' se sinh HAI hang cung mot nang luc, mot ⬜ mot ✅. Xoa han thi B01 thuan rebrand va KHONG con xung dot nao.
…1 o do, gap-probe 5 finding da sua, chot pham vi o trang thai V Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…anh b01, day CI - scripts/fork/check-fork-identity.sh: quet lop dinh danh upstream tren bo file khai truoc, mien tru khai truoc theo ngu canh (tep, mau, ly do), banh coc hai chieu, 18 khang dinh duong co ten; ten kho tu conf doi chieu git remote. - scripts/fork/check-fork-identity-teeth.sh: 28 ca, moi ca pha dung mot bien. - scripts/fork/check-prototype-lane.sh, check-suite-key.sh: lan keep + suite key. - README_ZH/JA: badge ve fork; CONTRIBUTING: clone URL ve fork; compose them build: .; ba README noi that anh chi co sau tag v* dau tien. - ci.yml + check-gate-guards-job.sh: hai step moi, needle + pha-thu rieng. - PRODUCT-MAP.md: muc Dang lam cho mo-hoa-b01 (va tay — bo sinh kit lech bo kiem). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… exit khac 0 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… chung vong 1 - check-prototype-lane.sh: giai nhanh chinh main roi origin/main; khong giai duoc -> exit 2 (checkout PR tren CI la detached HEAD khong co main). - rang image-upstream ghim dung cau FAIL; rang conf-remote-lech ghim ca hai gia tri, remote doc tu git, repo doc tu conf. - run-log.jsonl 22 dong, evidence-report.md + review-findings.md vong 1 (REJECT, 0 o do, 10 finding: 3 trong / 7 ngoai hop dong), entry fix S4-r1. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…status verified - run-log.jsonl 44 dong (hai vong), evidence-report.md + review-findings.md vong 2 (0 o do, carry E8+E9, triage hong nen may KHONG tu sua: 9 finding cho nguoi o Cong 2). - usage-report.md hai vong. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…idence-page.html Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…hai chieu
Finding HIGH «Trong hop dong» cua vong verify: run_one goi ca bang
`if "case_$name"; then`. Bash bo qua errexit trong TOAN THAN mot ham chay o vi
tri dieu kien, nen `return 1` cua green_control khong dung ca lai — ca van pha
fixture, guard van do (vi ly do khac), expect_red van thay token, va ca duoc
dem la PASS. 24/28 ca mang benh nay.
Do them mot benh thu hai cung goc: 5 loi goi expect_red NAM TRONG for loop
khong phai lenh cuoi ham, nen mot vong that bai bi vong sau ghi de.
Sua: them `|| return 1` vao 25 loi goi green_control + 5 expect_red trong for.
18 expect_red la lenh cuoi ham giu nguyen — chung khong co benh.
Doi chung hai chieu, do that:
- chieu xanh: 28/28 ca PASS tren cay lanh, exit 0
- chieu do, conf pha (repo=ai-do/kho-khac):
TRUOC image-upstream exit=0 + in "CASE image-upstream: PASS"
SAU image-upstream exit=1 + khong in PASS
(hit-outside, readme-image-missing cung vay)
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
b24bd89 Bang chung ghim lai tai b24bd89. Finding HIGH «Trong hop dong» cua AC-7 danh dau DA SUA, kem doi chung hai chieu trong evidence-report muc Round 3. Verdict may VAN la PENDING-JUDGMENT: no den tu vong 2, khi buoc phan loai pham vi khong chay duoc — khong phai tu mot o do do. Do la viec cua nguoi o Cong 2. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nguoi ky: Phan Le Manh, 07/09/2026. Chu nguyen van: «Ky». Nhan nguyen khuyen nghi may cho bay muc ngoai hop dong (bon known-limits, ba wont-fix) va treo hinh 5 — bo rang dem ba dong mien tru thay vi ghim ten, hai dong desktop-release chua duoc canh. Ky DU phan quyet may la PENDING-JUDGMENT. No den tu vong 2 khi buoc phan loai pham vi khong chay duoc, khong tu mot o do nao do: 11/11 o do xanh tai b24bd89, va finding HIGH trong hop dong da dong voi doi chung hai chieu. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…xit 0 Vong 3 verify tra REJECT (E8, E9). Bon finding keo REJECT deu cung mot goc: chu ky duoc ghi ma so sach di theo thi khong. Do la loi cua phien dieu phoi, khong phai cua san pham. Sua nam cho: - PRODUCT-MAP.md: doi mo-hoa-b01 tu «Dang lam» sang «cho phien nghiem thu», sua hai nut mermaid - docs/roadmap.md: them hang so cai, tick dong B2 ⬜ -> ✅, doan ti le 37 -> 38 - STATUS.md: gach no B2 kem ngay ky, doi ngay muc Hien trang, 37 -> 38 ho so Do lai: check-product-map · check-roadmap-fresh · check-plan-docs · check-plan-freeze deu exit 0; E8 exit 0; E9 exit 0. Ke hoach nay ★ 3/16. Diem dang ghi: che do teeth cua check-gate-guards-job dung o needle DAU vi cay khong lanh, nen bo rang fork-identity ma vong nay dung ra CHUA TUNG duoc chay trong cong o HEAD do. run_log_write_failed: true — cac dong run-log vong 3 do phien ghi tay. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…i, sau cam bay Viet cho phien ke tiep (tai khoan khac): doc file nay + evidence-report muc «Vong 3» la du de tiep, khong can lich su hoi thoai. Gom: ho so dang o dau · hai viec cho nguoi quyet (doi ten volume lam mat du lieu nguoi tu host, va chu ky can xac nhan lai sau mot vong 4) · tam finding con lai · sau cam bay phien nay vap · cach chay lai vong 4 · viec don nha da ra soat nhung chua lam. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… du lieu khi pull Vong 3 verify cua mo-hoa-b01 tim ra mot finding high ngoai hop dong, chua tung len ban nguoi ky: doi khoa volume tongflow-data/tongflow-plugins thanh oneflow-* lam ai dang tu host `git pull && docker compose up -d` nhan hai volume RONG (SQLite, tep tai len, /data/settings.json, venv plugin nam lai volume cu), app len nhu ban cai moi, khong loi khong canh bao. Compose dat ten volume that la `<project>_<key>`, nen `name: tongflow-data` tran KHONG khop volume cu — loi dung la giu nguyen khoa. Service van la `oneflow`, image van la ghcr.io/phanlemanh/oneflow. Ba README sua dong `docker run -v` cho khop. Do lai: check-fork-identity.sh PASS; teeth 28/28 PASS, exit 0 (lop quet chi canh URL/domain thuong nguon, khong canh ten volume). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…nguoi ky, ban giao cap nhat review-findings.md them muc [DA SUA] cho finding high ngoai hop dong (truoc day chi nam o van xuoi vong 3); evidence-report.md ghi loi da chon va so do lai; decisions.jsonl them quyet dinh fix02; HANDOFF.md danh dau muc 1 da xu, con muc 2 (ky lai + vong 4). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Chu ky dau dung tren bang chung vong 2, chua thay finding high ngoai hop dong (doi khoa volume compose). Nguoi ky chon loi giu khoa volume cu (6cb2253) roi ky lai. Bay muc known-limits/wont-fix va hinh 5 treo giu nguyen. Vong 4 chay sau commit nay de evidence ghim dung HEAD cuoi. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…nh, ghi so tu ket qua workflow evidence-report.md: ban bao cao workflow sinh (verdict PASS, verified_commit cd15d1d) + giu nguyen su lieu vong 3 viet tay + muc Vong 4. run-log.jsonl: 21 dong append NGUYEN VAN tu result.runLog (workflow ghi ro main loop tu append). review-findings.md: ba finding moi ngoai hop dong danh dau VONG 4 (orphan container khi doi ten service — cho nguoi ky quyet; guard do tren fork contributor; prototype-lane uu tien main cuc bo), bon muc con lai trung Known limits da ky. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ecreate tai cho, khong mo coi Vong 4 verify tim ra finding cung lop voi vu volume: doi khoa service tongflow -> oneflow lam self-host cu `git pull && docker compose up -d` de lai container <project>-tongflow-1 mo coi (restart: unless-stopped) giu cong 3000, container moi khong len. Nguoi ky chon giu ten service nhu da giu khoa volume; image van la ghcr.io/phanlemanh/oneflow, khong README nao ghim ten service. Do lai: docker compose config OK; check-fork-identity PASS; check-docker-dryrun exit 0; teeth 28/28 exit 0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…uyet dinh nguoi ky, cho vong 5 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…nguon chen len dong da mien tru van do Vong 5 verify (AC-6, high, trong hop dong): guard so allow-regex voi CA DONG, nen mot dong da mien tru cho ghi cong lai mien tru luon moi mention khac cung dong (tai hien: chen discord.gg / ghcr.io/tong-io len dong 3 NOTICE.md, guard van PASS). Sua: sau khi khop mien tru, cat cac doan da khop khoi dong roi quet lai phan con lai bang chinh pattern; con hit thi FAIL "chung dong voi muc da mien tru". Them ca rang exempt-line-smuggle; E7 ghim 29/29; design §6 them hang. Do lai: ca moi PASS; rang 29/29 exit 0; guard cay lanh PASS; E6/E8 exit 0; tai hien tren ban sao: FAIL dung thong diep, exit 1. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…i ngoai hop dong, vong 6 la vong chot Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…i ngoai hop dong (bfe8817 chi mang run-log) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… thuong, bang no dem dung mot hang, chuoi anh neo vao khoi docker run AC-6: grep -i cho lop quet, mien tru va phan con lai cua dong — link Tong-io/TongFlow viet hoa thuong lan lon nay la hit. AC-11: check-prototype-lane dem hang no, 0 = thieu, >1 = "can dung mot". AC-1: chuoi anh phai nam TRONG khoi `docker run` (dong bat dau docker run, noi bang dau gach cheo nguoc), nhac o van xuoi khong tinh. Ba ca rang readme-image-outside-run / class-mixed-case / debt-table-duplicate; E7 ghim 32/32; executor mhb_teeth_image / mhb_teeth_ratchet / mhb_prototype_lane noi ca moi; design §6 them ba hang. Do lai: 32/32 exit 0; guard + lane cay lanh PASS; bon executor exit 0; chieu do tren ban sao: hai FAIL dung thong diep. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…0d3c124, luat chan xoay nguoi ky duyet Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…oay, chu ky vao evidence, 22 no co ten Vong 7 (bb2b05d): 12 finding, khong muc nao trong hop dong; may BLOCKED do ha tang (agent E9 chet, E8 do duoi tai — tuan tu exit 0). Vong 8 cuc gon cung HEAD, mang theo 9 o xanh cua vong 7 (carriedEvals), E8/E9 + suite xanh: PASS. evidence-report: bao cao workflow + human_signoff + Known limits (7 da ky + 22 no co ten tu muc Amendment cua contract) + Ngoai hop dong (tu review-findings) — hai muc bo tong hop kit luon de rong khien luoi doc "xanh-sach, khong moi ky". contract: muc Amendment sau luat chan xoay. review-findings: 12 muc vong 7, 13 muc vong 8. run-log: vong 7 + 8 nguyen van. roadmap: so cai ghi 32 ca va hang mo-hoa-b01 ve dung bang (xoa dong trong). Hai muc cai dat kho (Discussions, Private vulnerability reporting dang tat) la viec cua owner truoc merge. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B2 của khối kế hoạch lát cắt chứng minh — hạ cánh nhánh mở hoá
b01Hồ sơ nghiệm thu:
_acceptance/mo-hoa-b01/(T2, làn prototype keep,prototype.base_commit = 5547aff).Người tự host thấy gì khác
docker-compose.ymltrỏ ảnhghcr.io/phanlemanh/oneflow; tài liệu nói thật rằng ảnh chỉ có sau tagv*đầu tiên và compose dựng tại chỗ được ngay (docker compose up -d --build).v*chỉ đẩy ảnh Docker; workflow desktop không còn trigger tag (DISARMED), Release checklist trong CLAUDE.md khớp hành vi thật.scripts/fork/check-fork-identity.sh+ răng 28 ca, dây vào job Acceptance Gate và guard-của-guard;fork_identitylà suite key.Ba khoản nợ nhánh cũ bỏ sót đã trả: badge README_ZH/JA còn trỏ upstream · lệnh clone trong CONTRIBUTING · ảnh GHCR chưa tồn tại (404).
Trạng thái cổng: S4 hai vòng, 11/11 ô đo PASS cả hai vòng, verdict vòng 2
PENDING-JUDGMENT(phân loại phạm vi hỏng → máy không tự sửa). Chờ owner ký Cổng 2:/acceptance-gate:signoff mo-hoa-b01 …— thẻ ở_acceptance/mo-hoa-b01/card.html, gói bằng chứng ởevidence-page.html.Sau khi ký (cùng commit, để CI không đỏ): STATUS.md
38 hồ sơ đã ký+ ngày tiêu đề2026-09-05+ xoá dòng nhánhb01khỏi «7 nhánh chưa về main»; docs/roadmap.md dòng B2⬜ → ✅, thêm hàng sổ cáimo-hoa-b01, đoạn tỉ lệtrên 38 hồ sơ(17/38 · 5/38 · 16/38); PRODUCT-MAP.md chuyểnmo-hoa-b01từ «Đang làm» sang «Đã giao». Rồi re-pin các hồ sơ bị chạm (check-gate-guards-job.shnằm trongpathscủa cong-tu-canh-minh và lat-cat-chung-minh).Việc của owner ngoài repo (từ hội đồng): bật GitHub Discussions cho kho hoặc đổi sáu link hỗ trợ sang Issues; CODE_OF_CONDUCT.md còn
business@tongflow.com.🤖 Generated with Claude Code