add better messaging to ard_stack_hierarchical - #593
Open
alanahjonas95 wants to merge 8 commits into
Open
Conversation
ard_stack_hierarchical
Contributor
Unit Tests Summary 1 files 276 suites 18s ⏱️ Results for commit 7675dc6. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit aa16f90 ♻️ This comment has been updated with latest results. |
alanahjonas95
marked this pull request as draft
August 7, 2026 08:45
alanahjonas95
marked this pull request as ready for review
August 12, 2026 09:35
Contributor
Code Coverage SummaryDiff against mainResults for commit: 705416a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
NEWS.md. (#, @)Provide more detail here as needed.
Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #525
ard_stack_hierarchical()now informs users when columns in thebyargument are not present indenominator, clarifying that subjects with multiple values in those columns are counted once in the last sorted level.Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).Optional Reverse Dependency Checks:
Install
checkedwithpak::pak("Genentech/checked")orpak::pak("checked")