Skip to content

Fix world menu parent for rewriter tools to Browsing - #1534

Merged
Ducasse merged 1 commit into
pharo-spec:Pharo15from
PrasannaBhavan2005:fix-expose-rewriter-rule-editor
Sep 22, 2026
Merged

Ducasse merged 1 commit into
pharo-spec:Pharo15from
PrasannaBhavan2005:fix-expose-rewriter-rule-editor

Conversation

@PrasannaBhavan2005

Copy link
Copy Markdown
Contributor

Fixes #1532
Addresses pharo-project/pharo#20015

Changes the parent: symbol in menuCommandOn: from #Tools to #Browsing for:

  • StRewriterRuleEditorPresenter
  • StRewriterExpressionFinderPresenter
  • StRewriterMatchToolPresenter

This ensures these tools are properly registered and visible under the Browse category in the Pharo World Menu.

@PrasannaBhavan2005

Copy link
Copy Markdown
Contributor Author

@Ducasse I have fixed this, can you look into it please.

@Ducasse

Ducasse commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Tx!

@Ducasse
Ducasse merged commit f31e9fd into pharo-spec:Pharo15 Sep 22, 2026
1 of 2 checks passed
@PrasannaBhavan2005

Copy link
Copy Markdown
Contributor Author

Thanks @Ducasse . I see it failed on Check 2, do I have to look into it?

@PrasannaBhavan2005

Copy link
Copy Markdown
Contributor Author

And also like I wanted to ask, can I become a community member of Pharo organisation, I have been making a lot of contributions to Pharo since some time.

@Ducasse

Ducasse commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contributions they help Pharo. Now we have the policy that we limit the number of members of the organisation. I even proposed to remove myself from and that even this small group does not have push direct rights. So we embrace the PR git workflow because it helps us making mistakes and being able to revert.
Now I'm not expert in roles so what I suggest is keep helping. Not being a member does not impact much and we can check the roles proposed and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose in a menu the code rewriter

2 participants