Repository navigation
Raise the package validation baseline to 0.8.0 - #37
Merged
Merged
Conversation
0.8.0 is published, so package validation now compares against it, and the suppression files for the breaks it shipped are no longer needed (docs/versioning.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YagvELyJKBANk61DyFGUNJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.8.0 is on nuget.org, so this follows the post-release step in
docs/versioning.md:PackageValidationBaselineVersioninsrc/Directory.Build.propsfrom 0.7.2 to 0.8.0. Package validation now also checks APIs added in 0.8.0, such asS57LongName,EnumerateRecordsand the ordinal getters.src/EncDotNet.Iso8211/CompatibilitySuppressions.xmlandsrc/EncDotNet.S57/CompatibilitySuppressions.xml. The breaks they accepted (Iso8211Field.Data,S57FeaturePointer.Name,S57Chart.ReferencingFeatures) are part of the new baseline.Locally,
dotnet pack -c Releasepasses for EncDotNet.Iso8211, EncDotNet.S57 and EncDotNet.Noaa against the downloaded 0.8.0 packages, with no suppression files.Standards alignment
iso8211)s57-enc)chart-viewer)Standard section references cited in code or docs:
None.
Tests
tests/. Not needed: no code changes.dotnet test --configuration Releasepasses locally. Unit tests: 531 pass. Budget tests: 14 pass.Documentation
src/<project>/README.md. Not needed.docs/if user-facing behavior changed. Not needed.docfx docfx.json --warningsAsErrorspasses, if docs changed. Not applicable: no docs changed.Dependencies
Directory.Packages.props(not in the.csproj)gh-advisory-databasesecurity check run for any new dependency. Not applicable: no new dependencies.Breaking changes
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YagvELyJKBANk61DyFGUNJ
Generated by Claude Code