Skip to content

Emit log event and simplify editor shortcut configuration - #175

Merged
SteffenDE merged 5 commits into
mainfrom
sd-log-simplify-shortcut
Jul 23, 2026
Merged

SteffenDE merged 5 commits into
mainfrom
sd-log-simplify-shortcut

Conversation

@SteffenDE

Copy link
Copy Markdown
Member

No description provided.

@SteffenDE

Copy link
Copy Markdown
Member Author

@josevalim draft because I have not yet decided on how to expose more log metadata

@SteffenDE
SteffenDE force-pushed the sd-log-simplify-shortcut branch from 136cf57 to 71e3db3 Compare July 21, 2026 11:00
Comment thread priv/static/phoenix_live_reload.js Outdated
@SteffenDE

Copy link
Copy Markdown
Member Author

(I'll send a PR to bump the minimum Elixir requirement and CI)

@josevalim

Copy link
Copy Markdown
Member

@josevalim draft because I have not yet decided on how to expose more log metadata

My suggestion is to have a config :phoenix_live_reloader, :forward_metadata, [:foo, :bar]. That is sent as an additional metadata key. The keys must be encodable to json. Then we just do: metadata: Map.take(metadata, ...). By default, we can include agentic_prompt, application, registered_name, etc and a few others that may be useful.

@josevalim

Copy link
Copy Markdown
Member

(I'll send a PR to bump the minimum Elixir requirement and CI)

I think last time we bumped everything to v1.14 (the earliest supported in the oldest ubuntu images).

@SteffenDE
SteffenDE force-pushed the sd-log-simplify-shortcut branch from 71e3db3 to f332dec Compare July 21, 2026 11:57
@SteffenDE
SteffenDE marked this pull request as ready for review July 21, 2026 12:10
@SteffenDE

Copy link
Copy Markdown
Member Author

Should we just assume it's JSON encodable and let it crash if not?

I let it default to [] for now. tidewave_phoenix could then inject agentic_prompt.

@josevalim

Copy link
Copy Markdown
Member

I let it default to [] for now. tidewave_phoenix could then inject agentic_prompt.

Sounds good. Or include :application.

Should we just assume it's JSON encodable and let it crash if not?

Yes. But let's document the configuration and document this behaviour!

@SteffenDE
SteffenDE merged commit 93cb716 into main Jul 23, 2026
4 checks passed
@SteffenDE
SteffenDE deleted the sd-log-simplify-shortcut branch July 23, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants