Skip to content

Fix record: missing @throws tag on Result::loadFromMysqliResult() #62

Closed

Description

@tyrsson

Context

Part of #60.

Data

Result::loadFromMysqliResult() gained a guard clause in an earlier commit on this branch (fixing a non-existent-method finding, tracked in issue #59). That guard throws PhpDb\Adapter\Exception\RuntimeException, but the method's docblock was missing the corresponding @throws tag, which mago analyze then flagged as unhandled-thrown-type.

Fixed in 5fae58c by adding @throws Exception\RuntimeException to the method's docblock.

This issue is a record of where/why the gap was introduced. Close once confirmed it does not resurface.

Activity

  1. linked a pull request that will close this issueFix mago analyze findings (WIP) #60on Aug 10, 2026
  2. added this to the 0.5.0 milestone on Aug 10, 2026
  3. added theissue type on Aug 10, 2026
  4. tyrsson commented on Oct 7, 2026

    @tyrsson
    MemberAuthor

    Closing as confirmed fixed. Result::loadFromMysqliResult() carries @throws Exception\RuntimeException (src/Result.php), added in 5fae58c, and mago analyze reports no unhandled-thrown-type against the current baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions