Skip to content

Fix Driver imports and untyped property; prune dead mago baseline entries #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrsson merged 2 commits into from
Oct 7, 2026
Merged

Fix Driver imports and untyped property; prune dead mago baseline entries #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16ef81c
Add missing mysqli_result import to Driver and prune dead baseline en…
tyrsson Oct 7, 2026
079081f
Add native array type hint to Driver::$options
tyrsson Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions analysis-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ count = 1
[[issues]]
file = "src/Driver.php"
code = "incompatible-parameter-type"
message = 'Parameter `$resource` of `PhpDb\Mysql\Driver::createresult()` expects type `mysqli|mysqli_stmt|unknown-ref(PhpDb\Mysql\mysqli_result)` but parent `PhpDb\Adapter\Driver\DriverInterface::createresult()` expects type `resource`'
message = 'Parameter `$resource` of `PhpDb\Mysql\Driver::createresult()` expects type `mysqli|mysqli_result|mysqli_stmt` but parent `PhpDb\Adapter\Driver\DriverInterface::createresult()` expects type `resource`'
count = 1

[[issues]]
Expand All @@ -276,24 +276,6 @@ code = "incompatible-parameter-type"
message = 'Parameter `$sqlOrResource` of `PhpDb\Mysql\Driver::createstatement()` expects type `mysqli|mysqli_stmt|string` but parent `PhpDb\Adapter\Driver\DriverInterface::createstatement()` expects type `resource|string`'
count = 1

[[issues]]
file = "src/Driver.php"
code = "missing-property-type"
message = "Property `$options` is missing a type hint."
count = 1

[[issues]]
file = "src/Driver.php"
code = "non-existent-class-like"
message = 'Cannot find class, interface, enum, or type alias `PhpDb\Mysql\mysqli_result`.'
count = 1

[[issues]]
file = "src/Driver.php"
code = "possibly-invalid-argument"
message = 'Possible argument type mismatch for argument #1 of `PhpDb\Mysql\Result::initialize`: expected `mysqli|mysqli_result|mysqli_stmt`, but possibly received `mysqli|mysqli_stmt|unknown-ref(PhpDb\Mysql\mysqli_result)`.'
count = 1

[[issues]]
file = "src/Metadata/Source.php"
code = "impossible-condition"
Expand Down
5 changes: 3 additions & 2 deletions src/Driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace PhpDb\Mysql;

use mysqli;
use mysqli_result;
use mysqli_stmt;
use Override;
use PhpDb\Adapter\Driver\ConnectionInterface;
Expand All @@ -23,8 +24,8 @@ final class Driver implements DriverInterface, ProfilerAwareInterface
{
protected ?ProfilerInterface $profiler = null;

/** @var array */
protected $options = [
/** @var array $options */
protected array $options = [
'buffer_results' => false,
];

Expand Down
Loading