Skip to content

AdapterAbstractServiceFactory #68

Closed

Description

@tyrsson

Package Version

0.1.0

Php Version

8.2

Database Engine

None

Basic Information

AbstractServiceFactory being responsible for creating named adapters is almost certainly broken for several reasons at the moment.

  • Config Structure change
  • Introduction of ConnectionInterfaceFactory
  • Introduction of AdapterManager

I will be opening a PR to resolve this issue. Got a couple different ideas on how we can address this.

Steps to Reproduce

Expected Behavior

No response

Actual behavior?

n/a

Additional Info

No response

Activity

  1. added this to the 0.2.0 milestone on Sep 5, 2025
  2. self-assigned this
    on Sep 5, 2025
  3. added theissue type on Sep 5, 2025
  4. added
    bugSomething isn't working
    enhancementNew feature or request
    confirmedHas been confirmed by maintainers
    on Sep 5, 2025
  5. linked a pull request that will close this issueAbstractAdapterServiceFactory Refactor #70on Sep 9, 2025
  6. changed the title [-]AbstractServiceFactory[/-] [+]AdapterAbstractServiceFactory[/+] on Sep 9, 2025
  7. tyrsson commented on Sep 9, 2025

    @tyrsson
    MemberAuthor

    I have opened draft PR's to both php-db/phpdb and php-db/phpdb-adapter-mysql to address the issue with the AdapterAbstractServiceFactory.

    The work is very early, as in, just make it work. I edit the issue above with implementation details tomorrow.
    @settermjd @simon-mundy

  8. modified the milestones: 0.2.0, 0.1.1 on Sep 16, 2025
  9. moved this from Todo to Done in @phpdbon Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingconfirmedHas been confirmed by maintainersenhancementNew feature or request

Type

Projects

  • Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions