You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the sake of consistency within code and also to assist with concrete implementation of TableGatewayInterface, the interface for both ResultSet\ResultsetInterface and Driver\ResultInterface should implement both Countable and Iterator.
This way we get to use count(), current(), key(), next(), rewind() and valid() and our code quality tools can correctly hint for us.
Or you can create the branch via the project. This automatically adds it to project tracking which means it will automatically move it to complete when the PR is merged. This way stale branches are not left when they are not removed post merge. That is what I am trying to prevent. There is already several that needs attention.
Activity
simon-mundy commentedon Nov 5, 2025
For the sake of consistency within code and also to assist with concrete implementation of TableGatewayInterface, the interface for both ResultSet\ResultsetInterface and Driver\ResultInterface should implement both Countable and Iterator.
This way we get to use count(), current(), key(), next(), rewind() and valid() and our code quality tools can correctly hint for us.
tyrsson commentedon Nov 5, 2025
I thought valid was for FilteringIterator?
simon-mundy commentedon Nov 6, 2025
It may be but it's also part of Iterator. Do you want me to do a PR for this or are you OK to add to existing repo?
tyrsson commentedon Nov 7, 2025
Since we move to semver and minors its always from a PR. Its easier to keep the main repo clean of branches.
tyrsson commentedon Nov 7, 2025
Or you can create the branch via the project. This automatically adds it to project tracking which means it will automatically move it to complete when the PR is merged. This way stale branches are not left when they are not removed post merge. That is what I am trying to prevent. There is already several that needs attention.
Addresses Issue #81