Skip to content

Clear the Mago lint baseline across the test suite #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-mundy merged 3 commits into from
Sep 29, 2026
Merged

Clear the Mago lint baseline across the test suite #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c6814b
Regenerate the Mago baselines under 1.50.0
simon-mundy Sep 29, 2026
08f8954
Apply the safe Mago lint fixes across the test suite
simon-mundy Sep 29, 2026
37c7a48
Import the Test attribute and regenerate the lint baseline
simon-mundy Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 26 additions & 98 deletions analyzer-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,13 +441,13 @@ count = 1
[[issues]]
file = "src/Adapter/Driver/Pdo/AbstractPdoConnection.php"
code = "mixed-argument"
message = 'Invalid argument type for argument #1 of `PhpDb\Adapter\Exception\InvalidQueryException::forDriverError`: expected `string`, but found `mixed`.'
message = 'Invalid argument type for argument #1 of `PhpDb\Adapter\Driver\DriverInterface::createResult`: expected `resource`, but found `mixed`.'
count = 1

[[issues]]
file = "src/Adapter/Driver/Pdo/AbstractPdoConnection.php"
code = "mixed-argument"
message = 'Invalid argument type for argument #1 of `PhpDb\Adapter\Driver\DriverInterface::createResult`: expected `resource`, but found `mixed`.'
message = 'Invalid argument type for argument #1 of `PhpDb\Adapter\Exception\InvalidQueryException::forDriverError`: expected `string`, but found `mixed`.'
count = 1

[[issues]]
Expand Down Expand Up @@ -834,12 +834,6 @@ code = "class-must-be-final"
message = 'Class `PhpDb\Adapter\Exception\ErrorException` should be declared `final`.'
count = 1

[[issues]]
file = "src/Adapter/Exception/ExceptionInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\Adapter\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Adapter/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
Expand Down Expand Up @@ -1386,12 +1380,6 @@ code = "mixed-assignment"
message = "Assigning `mixed` type to a variable may lead to unexpected behavior."
count = 2

[[issues]]
file = "src/Container/AdapterInterfaceDelegator.php"
code = "unhandled-thrown-type"
message = 'Potentially unhandled exception `PhpDb\Exception\RuntimeException` in `PhpDb\Container\AdapterInterfaceDelegator::__invoke`.'
count = 1

[[issues]]
file = "src/Container/AdapterInterfaceDelegator.php"
code = "unused-parameter"
Expand Down Expand Up @@ -1464,12 +1452,6 @@ code = "missing-api-or-internal"
message = 'Interface `PhpDb\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Metadata/Exception/ExceptionInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\Metadata\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Metadata/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
Expand Down Expand Up @@ -1518,12 +1500,6 @@ code = "missing-constant-type"
message = "Class constant `DEFAULT_SCHEMA` is missing a type hint."
count = 1

[[issues]]
file = "src/Metadata/Source/AbstractSource.php"
code = "unfulfilled-expect"
message = "This pragma was not used and may be removed."
count = 3

[[issues]]
file = "src/ResultSet/AbstractResultSet.php"
code = "imprecise-type"
Expand Down Expand Up @@ -1662,12 +1638,6 @@ code = "imprecise-type"
message = "Type `array` in return type of `toArray` is imprecise, equivalent to `array<array-key, mixed>`."
count = 1

[[issues]]
file = "src/ResultSet/Exception/ExceptionInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\ResultSet\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/ResultSet/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
Expand Down Expand Up @@ -1956,6 +1926,12 @@ code = "mixed-argument"
message = 'Invalid argument type for argument #1 of `PhpDb\RowGateway\AbstractRowGateway::populate`: expected `array<array-key, mixed>`, but found `mixed`.'
count = 1

[[issues]]
file = "src/RowGateway/AbstractRowGateway.php"
code = "mixed-argument"
message = 'Invalid argument type for argument #1 of `PhpDb\RowGateway\Exception\RuntimeException::forMissingPrimaryKeyData`: expected `string`, but found `mixed`.'
count = 1

[[issues]]
file = "src/RowGateway/AbstractRowGateway.php"
code = "mixed-argument"
Expand All @@ -1974,12 +1950,6 @@ code = "mixed-method-access"
message = "Attempting to access a method on a non-object type (`mixed`)."
count = 14

[[issues]]
file = "src/RowGateway/AbstractRowGateway.php"
code = "mixed-argument"
message = 'Invalid argument type for argument #1 of `PhpDb\RowGateway\Exception\RuntimeException::forMissingPrimaryKeyData`: expected `string`, but found `mixed`.'
count = 1

[[issues]]
file = "src/RowGateway/AbstractRowGateway.php"
code = "mixed-operand"
Expand Down Expand Up @@ -2064,12 +2034,6 @@ code = "unhandled-thrown-type"
message = 'Potentially unhandled exception `PhpDb\RowGateway\Exception\RuntimeException` in `PhpDb\RowGateway\AbstractRowGateway::save`.'
count = 1

[[issues]]
file = "src/RowGateway/Exception/ExceptionInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\RowGateway\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/RowGateway/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
Expand Down Expand Up @@ -3426,24 +3390,6 @@ code = "redundant-null-coalesce"
message = "Redundant null coalesce: left-hand side can never be `null` or undefined."
count = 1

[[issues]]
file = "src/Sql/Exception/ExceptionInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\Sql\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Exception\InvalidArgumentException` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Exception/RuntimeException.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Exception\RuntimeException` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Expression.php"
code = "imprecise-type"
Expand Down Expand Up @@ -3819,7 +3765,7 @@ count = 1
[[issues]]
file = "src/Sql/Join.php"
code = "mixed-argument"
message = "Invalid argument type for argument #1 of `PhpDb\\Sql\\Exception\\InvalidArgumentException::forInvalidJoinName`: expected `string`, but found `mixed`."
message = 'Invalid argument type for argument #1 of `PhpDb\Sql\Exception\InvalidArgumentException::forInvalidJoinName`: expected `string`, but found `mixed`.'
count = 1

[[issues]]
Expand Down Expand Up @@ -3990,6 +3936,18 @@ code = "missing-api-or-internal"
message = 'Interface `PhpDb\Sql\Platform\PlatformDecoratorInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Predicate/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Predicate\Exception\InvalidArgumentException` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Predicate/Exception/RuntimeException.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Predicate\Exception\RuntimeException` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Predicate/Expression.php"
code = "class-must-be-final"
Expand Down Expand Up @@ -4206,12 +4164,6 @@ code = "possibly-invalid-argument"
message = 'Possible argument type mismatch for argument #3 of `PhpDb\Sql\Predicate\Between::__construct`: expected `PhpDb\Sql\ArgumentInterface|float|int|null|string`, but possibly received `PhpDb\Sql\ArgumentInterface|array<array-key, mixed>|float|int|null|string`.'
count = 2

[[issues]]
file = "src/Sql/Predicate/Predicate.php"
code = "unhandled-thrown-type"
message = 'Potentially unhandled exception `PhpDb\Sql\Exception\RuntimeException` in `PhpDb\Sql\Predicate\Predicate::unnest`.'
count = 1

[[issues]]
file = "src/Sql/Predicate/PredicateInterface.php"
code = "missing-api-or-internal"
Expand Down Expand Up @@ -4905,20 +4857,20 @@ count = 1
[[issues]]
file = "src/Sql/Sql.php"
code = "possibly-invalid-argument"
message = 'Possible argument type mismatch for argument #1 of `PhpDb\Sql\Insert::__construct`: expected `PhpDb\Sql\TableIdentifier|null|string`, but possibly received `PhpDb\Sql\TableIdentifier|array<array-key, mixed>|null|string`.'
count = 1
message = 'Possible argument type mismatch for argument #1 of `PhpDb\Sql\Exception\InvalidArgumentException::forForeignTable`: expected `string`, but possibly received `PhpDb\Sql\TableIdentifier|array<array-key, mixed>|string`.'
count = 4

[[issues]]
file = "src/Sql/Sql.php"
code = "possibly-invalid-argument"
message = 'Possible argument type mismatch for argument #1 of `PhpDb\Sql\Update::__construct`: expected `PhpDb\Sql\TableIdentifier|null|string`, but possibly received `PhpDb\Sql\TableIdentifier|array<array-key, mixed>|null|string`.'
message = 'Possible argument type mismatch for argument #1 of `PhpDb\Sql\Insert::__construct`: expected `PhpDb\Sql\TableIdentifier|null|string`, but possibly received `PhpDb\Sql\TableIdentifier|array<array-key, mixed>|null|string`.'
count = 1

[[issues]]
file = "src/Sql/Sql.php"
code = "possibly-invalid-argument"
message = 'Possible argument type mismatch for argument #1 of `PhpDb\Sql\Exception\InvalidArgumentException::forForeignTable`: expected `string`, but possibly received `PhpDb\Sql\TableIdentifier|array<array-key, mixed>|string`.'
count = 4
message = 'Possible argument type mismatch for argument #1 of `PhpDb\Sql\Update::__construct`: expected `PhpDb\Sql\TableIdentifier|null|string`, but possibly received `PhpDb\Sql\TableIdentifier|array<array-key, mixed>|null|string`.'
count = 1

[[issues]]
file = "src/Sql/Sql.php"
Expand Down Expand Up @@ -5466,12 +5418,6 @@ code = "redundant-comparison"
message = "Redundant `===` comparison: left-hand side is never identical to right-hand side."
count = 1

[[issues]]
file = "src/TableGateway/Exception/ExceptionInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\TableGateway\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/TableGateway/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
Expand Down Expand Up @@ -5537,21 +5483,3 @@ file = "src/TableGateway/TableGatewayInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\TableGateway\TableGatewayInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Predicate/Exception/ExceptionInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\Sql\Predicate\Exception\ExceptionInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Predicate/Exception/InvalidArgumentException.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Predicate\Exception\InvalidArgumentException` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Predicate/Exception/RuntimeException.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Predicate\Exception\RuntimeException` should be declared `final`.'
count = 1
Loading
Loading