[simon-mundy]

Depends on #203. Until it merges, this diff also shows #203's two commits; the change here is the last commit, "Describe Sql shapes in docblocks".

Adds docblock types across src/Sql, reducing Mago analyzer findings there from 636 to 423 (counted without the baseline). Docblocks only: with comments and whitespace stripped, every changed file has the same PHP token stream as before.

Changes

• AbstractSql declares Specification, SqlParameters and ColumnReference type aliases. Join declares JoinName and JoinSpecification, and implements Iterator<int, JoinSpecification>.
• Subclasses import Specification, so $specifications keeps one invariant type across Select, Insert, InsertIgnore, Update, Delete, Combine, CreateTable, AlterTable and DropTable.
• Select, Insert, Update, Delete and Sql type their table references, column lists, predicates and combine state. Each process* method describes the array it returns.
• DDL classes type their pending columns, constraints, drops, table options, column options and constraint/index column lists. The unresolvable @psalm-return tags on AlterTable's process* methods are replaced.
• Expression declares an ExpressionParameter alias. ExpressionInterface::getExpressionData() returns values as a list. PredicateSet types its predicate list, and In and Argument::values() type their value sets.
• The analyzer baseline is regenerated. Beyond the src/Sql entries, it gains entries for TableGateway, which passes untyped values into the newly typed parameters.

Breaking changes

None.

mago format, mago lint, mago analyze and the unit tests pass.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!