Skip to content

fix: run manager commands in the configured root directory without changing the PHP working directory, and prevent manager probes and npm dependency cleanup when manager execution is disabled. - #129

Merged
terabytesoftw merged 5 commits into
mainfrom
feat/run-manager-commands-configured-root-directory
Aug 25, 2026

Conversation

@terabytesoftw

Copy link
Copy Markdown
Contributor

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

…`^4.18.0` and remove legacy manager support.
…anging the PHP working directory, and prevent manager probes and npm dependency cleanup when manager execution is disabled.
@terabytesoftw terabytesoftw added the bug Something isn't working label Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b14517) to head (135b071).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #129   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       460       460           
===========================================
  Files             26        26           
  Lines           1095      1092    -3     
===========================================
- Hits            1095      1092    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 51 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f2c5a833-3984-4d15-8f87-04a4637eb514

📥 Commits

Reviewing files that changed from the base of the PR and between 7b14517 and 135b071.

📒 Files selected for processing (16)
  • CHANGELOG.md
  • README.md
  • UPGRADE.md
  • docs/config.md
  • docs/faqs.md
  • docs/index.md
  • src/Asset/AbstractAssetManager.php
  • src/Asset/AssetManagerFinder.php
  • src/Foxy.php
  • tests/Asset/AbstractAssetManagerTest.php
  • tests/Asset/AssetManager.php
  • tests/Asset/AssetManagerFinderTest.php
  • tests/Asset/NpmAssetManagerTest.php
  • tests/Fixtures/Util/AbstractProcessExecutorMock.php
  • tests/Fixtures/Util/ProcessExecutorMockTest.php
  • tests/FoxyTest.php
✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch feat/run-manager-commands-configured-root-directory
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/run-manager-commands-configured-root-directory

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@terabytesoftw
terabytesoftw merged commit 53d2141 into main Aug 25, 2026
30 of 31 checks passed
@terabytesoftw
terabytesoftw deleted the feat/run-manager-commands-configured-root-directory branch August 25, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant