Treat IDREF mismatches as warnings in non-English translations#303
Open
jordikroon wants to merge 1 commit into
Open
Treat IDREF mismatches as warnings in non-English translations#303jordikroon wants to merge 1 commit into
jordikroon wants to merge 1 commit into
Conversation
3eca0c5 to
90ebffd
Compare
Member
|
You can probably only count the lines that preg_match the message considered a warning. If the matched line count equals the output line count, then all lines are warned instead of errors, on translations. if ( ! is_array( $out ) )
$out = [];
$warnCount = 0;
foreach ( $out as $line )
if ( preg_match( $regex , $line ) )
$warnCount++;
$fatal = ( $isEnglish && count( $out ) > 0 ) || count( $out ) != $warnCount;Let the errors be outputted as is. There is no point sileting warnings of real problems. There are other parts of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For non-English translations, IDREF mismatches should be treated as warnings instead of errors.
Outdated translations may reference IDs that have yet to be translated from doc-en, thus results in a CI failure.