Add phpstan type to NewsHandler#1932
Open
markrandall wants to merge 1 commit into
Open
Conversation
markrandall
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
derickr
reviewed
Jun 18, 2026
| /** | ||
| * Unused - Looks up generated news with frontpage tags. | ||
| * | ||
| * Currently unused as the front page no longer displays news. |
Member
There was a problem hiding this comment.
That's not really true yet, right? That needs a whole lot more works than just this PR.
| /** | ||
| * @param NewsEntryStruct $data | ||
| */ | ||
| public static function parseTeaserCutoff(array $data): ?DateTimeImmutable |
Member
There was a problem hiding this comment.
These two seem to be new functions? I can't see where they're used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines shape of NewsHandler entry.