Skip to content

ci: run CI on every pull request - #4770

Merged
PierreBrisorgueil merged 1 commit into
masterfrom
ci/pr-ci-always
Oct 21, 2026
Merged

PierreBrisorgueil merged 1 commit into
masterfrom
ci/pr-ci-always

Conversation

@PierreBrisorgueil

@PierreBrisorgueil PierreBrisorgueil commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Master now requires CI (new "CI required" ruleset: Lint, Unit Tests & Build, E2E Tests). A docs-only PR skipped CI, so it could never merge: CI now runs on every PR.

https://claude.ai/code/session_01WUHv6mXE1DorM94XZFAv5y

Summary by CodeRabbit

  • Chores
    • Pull requests that modify Markdown, documentation, or .claude configuration files are now included in automated validation.
    • Push-based validation continues to exclude these file types.

Master now requires the CI checks. A docs-only PR skipped CI, so it could never merge.

Claude-Session: https://claude.ai/code/session_01WUHv6mXE1DorM94XZFAv5y
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pierreb-devkit/Vue/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a6cbb780-d2b2-471c-b285-c35d8c9f9e59
📥 Commits

Reviewing files that changed from the base of the PR and between 09bc4ca and b65a902.

📒 Files selected for processing: 1
  • .github/workflows/CI.yml
💤 Files with no reviewable changes: 1
  • .github/workflows/CI.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The CI workflow no longer ignores Markdown, documentation, or .claude/** changes for pull requests. The push trigger retains its path exclusions.

Changes

CI trigger filtering

Layer / File(s) Summary
Pull-request path filters
.github/workflows/CI.yml
The pull-request trigger no longer excludes Markdown, documentation, or .claude/** paths. Push-trigger exclusions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b65a9

Docs-only pull requests can now run the required CI checks. No merge-blocking concern is identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains what changed and why, but it omits most required template sections, including scope, validation, guardrails, and reviewer notes. Update the description with the required Summary, Scope, Validation, Guardrails check, and Notes for reviewers sections. Include impacted modules, risk level, validation results, guardrail confirmations, security considerations, mergeabilit…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: CI now runs on every pull request, including documentation-only pull requests.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Description check

Resolution

Update the description with the required Summary, Scope, Validation, Guardrails check, and Notes for reviewers sections. Include impacted modules, risk level, validation results, guardrail confirmations, security considerations, mergeability considerations, and rollback information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (c637db5) to head (b65a902).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4770   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          43       43           
  Lines        1585     1585           
  Branches      490      490           
=======================================
  Hits         1579     1579           
  Misses          6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PierreBrisorgueil
PierreBrisorgueil merged commit ada05ea into master Oct 21, 2026
7 checks passed
@PierreBrisorgueil
PierreBrisorgueil deleted the ci/pr-ci-always branch October 21, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant