Repository navigation
[Studio] Reuse the resolver step and mapping dialog outside the importer's editor - #707
Draft
markus-moser wants to merge 11 commits into
Draft
markus-moser wants to merge 11 commits into
markus-moser wants to merge 11 commits into
Conversation
…editor The mapping step reads its source data from a mapping source instead of a stored configuration name. The importer's own editor passes the stored configuration; other bundles post their mapping and records and get the previews from two new endpoints. The steps and the form converters are bound in Studio's container so other bundles can host them in their own forms. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ing limits Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
markus-moser
changed the title
…s in CI Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ping-steps Studio tests run on jest, as set up on 2026.x: the mapping source, step and dialog tests move next to their source and run in a jsdom project; vitest is dropped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets another bundle host the importer's resolver step and mapping dialog in its own form, on data that is not a stored import configuration.
PostedMappingSourceserves given columns and records and gets the transformation type and result previews from two new endpoints that take the posted mapping (POST /mapping/transformation-result-type,POST /mapping/transformation-result, permissionplugin_datahub_config).ResolverStep,AdvancedMappingModal,PostedMappingSourceand the two form converters are bound in Studio's container underDataImporter/Components/*andDataImporter/Utils/*.ResolverStepno longer takes the unusedconfigName. The dialog loads the default class attributes itself when its host has none.🤖 Generated with Claude Code
Part of pimcore/product-management#1577