Skip to content

Remove legacy inline frontend build workflow - #42

Merged
berfinyuksel merged 1 commit into
mainfrom
chore/remove-legacy-frontend-build-workflow
Sep 30, 2026
Merged

berfinyuksel merged 1 commit into
mainfrom
chore/remove-legacy-frontend-build-workflow

Conversation

@berfinyuksel

Copy link
Copy Markdown
Contributor

Removes `.github/workflows/studio-frontend-build.yaml`, the old inline lint / check-types / build pipeline.

It cannot pass on pull requests any more. Its `install` job saves `assets/node_modules` to `actions/cache` for the later jobs, but since GitHub's read-only Actions cache for untrusted triggers a `pull_request_target` run gets a read-only cache token. The save is denied (`cache write denied: token has no writable scopes`), `lint` and `check-types` restore nothing and fail with `eslint: not found` and `tsc` errors. Every `pull_request_target` run of this workflow since 2026-09-22 has failed, e.g. 35889926177.

Because `pull_request_target` always executes the copy on `main`, the failing checks keep appearing on #40 even though that PR deletes the file. Landing the deletion on `main` first clears them.

The replacement is the reusable packaged workflow wired in by #40 via `studio-frontend-build.yml`, which runs `npm ci` in every job and is green on that branch.

🤖 Generated with Claude Code

The install job saves node_modules to actions/cache for the lint and
check-types jobs. Since GitHub's read-only cache for untrusted triggers
(2026-06-26), pull_request_target runs cannot save, so those jobs start
with nothing installed and fail on every PR. The reusable packaged
workflow in studio-frontend-build.yml replaces it (see #40).
@berfinyuksel
berfinyuksel merged commit 8a83ed2 into main Sep 30, 2026
@berfinyuksel
berfinyuksel deleted the chore/remove-legacy-frontend-build-workflow branch September 30, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant