Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IP-based policies currently reject a socket address such as
[fe80::1%eth0]:1234before comparing it with the configured trusted IP or CIDR.net.SplitHostPortretains the interface zone, whichnet.ParseIPcannot parse. A trusted link-local proxy therefore fails policy classification, and the same problem affects local-interface and skip-CIDR policies.Parse the socket host with
netip.ParseAddrand compare its IP bytes. The zone identifies the local socket interface; these policies continue to match their configured IP addresses and networks. Regression fixtures exercise matching and nonmatching scoped TCP/UDP endpoints through all five policy paths. This concerns the underlying socket endpoints; the PROXY header parser is unchanged.Validation on Go 1.26.10: the ten matching fixtures fail on unchanged main, and the full race/shuffle/coverage suite passes with the fix.
go build ./...,go vet ./..., module tidiness, formatting, and golangci-lint v2.15.0 pass (zero lint issues). Tests use socket-address fixtures and the existing local test suite; no link-local deployment was exercised.