Repository navigation
Conversation
A default retention above the ceiling is silently capped, so the value the operator configured is never the one tasks get. Throw a TypeError at registration instead, comparing an explicit taskDefaultTtlMs against taskMaxTtlMs or its 1 hour default. An unset taskDefaultTtlMs is still capped by a smaller taskMaxTtlMs, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UF4S3w7iA83V9DVsasLJzM
mcollina
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #307, stacked on it. The base will become
mainonce #307 merges.A
taskDefaultTtlMsabovetaskMaxTtlMsis silently capped today, so tasks never get the retention the operator configured. This change makes registration throw aTypeErrorinstead:taskDefaultTtlMsis compared againsttaskMaxTtlMs, or against its 1 hour default whentaskMaxTtlMsis unset.taskDefaultTtlMs(60s default) is still capped by a smallertaskMaxTtlMs, as before.MAX_TASK_TTLis exported fromsrc/handlers.tsso registration can resolve the default ceiling.test/task-options-validation.test.tsupdated.Breaking change
Configurations with a
taskDefaultTtlMsabovetaskMaxTtlMsused to load, with the value capped. They now fail at startup. For example,taskDefaultTtlMs: 7_200_000with notaskMaxTtlMswas capped to 1 hour before.Refs #302
🤖 Generated with Claude Code
https://claude.ai/code/session_01UF4S3w7iA83V9DVsasLJzM