Skip to content

Reject iterable soft-login template parents - #3798

Merged
ksted merged 4 commits into
stablefrom
copilot/implement-array-validation-fix
Oct 16, 2026
Merged

ksted merged 4 commits into
stablefrom
copilot/implement-array-validation-fix

Conversation

Copilot AI commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Array-valued originalTemplate parameters such as ["/etc/passwd", "::"] bypass the proposed containment checks because Twig tests array membership and accepts arrays as parent candidates. IO #1266 validates only the top-level template; decoded parameters still reach Twig.

  • Guard

    • Includes the relevant guard from unmerged Ceres add check in template #3796, adding and originalTemplate is not iterable immediately after the defined check.
    • Preserves the order-confirmation fallback and valid plugin/core-style namespaced parents.
  • Documentation

    • Updates English/German changelogs and documents a loader-instrumented end-to-end check with IO Feature/add widget preview images #1266.
    • Scope is the array-valued guard bypass—not strict string validation, demonstrated file disclosure, or complete loader security.

Co-authored-by: ksted <43753494+ksted@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement minimal fix for originalTemplate validation bypass Reject iterable soft-login template parents Oct 16, 2026
Copilot AI requested a review from ksted October 16, 2026 08:13
@ksted
ksted changed the base branch from stable to chore/twig October 16, 2026 08:17
@ksted
ksted changed the base branch from chore/twig to stable October 16, 2026 08:18
ksted added 2 commits October 16, 2026 10:39
Removed detailed instructions for soft-login parent regression testing and manual end-to-end regression steps.
@ksted
ksted marked this pull request as ready for review October 16, 2026 08:47
@ksted
ksted merged commit 3cfcbf0 into stable Oct 16, 2026
@ksted
ksted deleted the copilot/implement-array-validation-fix branch October 16, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants