Repository navigation
fix deprecations - #1267
Merged
Merged
fix deprecations#1267
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused deprecation fixes have no identified blocking issues; tests and builds were not run.
0 open findings
What changed in this PR
Addresses PHP deprecations in shop services and extensions without changing intended behavior.
Changes:
- Makes nullable parameter types explicit.
- Removes the redundant
curl_close()call. - Casts a URL argument to string before checking its prefix.
| File | Description |
|---|---|
| src/Services/NotificationService.php | Makes placeholder arrays explicitly nullable. |
| src/Services/CountryService.php | Makes the language parameter explicitly nullable. |
| src/Services/CategoryService.php | Makes navigation language parameters explicitly nullable. |
| src/Guards/AbstractGuard.php | Makes the URI parameter explicitly nullable. |
| src/Extensions/Functions/ExternalContent.php | Removes explicit cURL handle closing. |
| src/Extensions/Constants/ShopUrls.php | Casts the URL before its prefix check. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ksted
previously approved these changes
Oct 16, 2026
ggottwald
approved these changes
Oct 16, 2026
stentrop
enabled auto-merge
October 16, 2026 09:15
ksted
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All changes meet the following requirements
@plentymarkets/plentyshop