Skip to content

Use plot title as default filename for "Download plot" button #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 13 commits into from
Jun 17, 2026
Merged

Use plot title as default filename for "Download plot" button #7828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6d907c1
use plot title for download filename, and change fallback to plot-ima…
emilykl Jun 8, 2026
5c96fa4
add tests
emilykl Jun 8, 2026
7cf0e1f
slightly change notifier wording for image download
emilykl Jun 8, 2026
1d8668a
ignore tex titles for filename
emilykl Jun 8, 2026
0a74890
expand forbidden chars
emilykl Jun 9, 2026
6a487f0
update locales files
emilykl Jun 9, 2026
93599ac
also remove = + ; chars from filenames
emilykl Jun 16, 2026
2cfef6d
Apply suggestion from @camdecoster
emilykl Jun 16, 2026
7b7753f
update translations
emilykl Jun 16, 2026
fc722c3
fall back to plot subtitle if title is not suitable for filename
emilykl Jun 16, 2026
9c1d9a0
exclude ALMOST ALL symbols and punctuation (more aggressive, using Un…
emilykl Jun 16, 2026
8895c4c
ignore biome rule
emilykl Jun 17, 2026
d8e3bf9
Update src/lib/svg_text_utils.js
emilykl Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/locales/cs.js
View file
Open in desktop
Comment thread
emilykl marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Obnovit nastavení pohledu', // components/modebar/buttons.js:583
'Reset views': 'Obnovit nastavení pohledů', // components/modebar/buttons.js:529
'Show closest data on hover': 'Zobrazit najbližší hodnotu při najetí myší', // components/modebar/buttons.js:157
'Snapshot succeeded': 'Snímek vytvořen', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your snapshot!': 'Omlouváme se, ale došlo k chybě stahování snímku!', // components/modebar/buttons.js:69
'Taking snapshot - this may take a few seconds': 'Vytváří se snímek - může zabrat pár vteřin', // components/modebar/buttons.js:57
'Image download succeeded': 'Stažení obrázku proběhlo úspěšně', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your image!': 'Omlouváme se, ale došlo k chybě při stahování obrázku!', // components/modebar/buttons.js:69
'Preparing image - this may take a few seconds': 'Připravuje se obrázek - může zabrat pár vteřin', // components/modebar/buttons.js:57
'Zoom': 'Zvětšení', // components/modebar/buttons.js:85
'Zoom in': 'Zvětšit', // components/modebar/buttons.js:121
'Zoom out': 'Zmenšit', // components/modebar/buttons.js:130
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Ailosodwch y golwg', // components / modebar / buttons.js: 592
'Reset views': 'Ailosod olygfeydd', // components / modebar / buttons.js: 540
'Show closest data on hover': 'Dangos y data agosaf wrth hofran', // components / modebar / buttons.js: 168
'Snapshot succeeded': 'Llwyddodd y Ciplun', // components / modebar / buttons.js: 77
'Sorry, there was a problem downloading your snapshot!': 'Mae\'n ddrwg gennym, roedd problem wrth lawrlwytho eich ciplun!', // components / modebar / buttons.js: 80
'Taking snapshot - this may take a few seconds': 'Tynnu ciplun - gallai hyn gymryd ychydig o eiliadau', // components / modebar / buttons.js: 62
'Image download succeeded': 'Llwyddwyd i lawrlwytho\'r ddelwedd', // components / modebar / buttons.js: 77
'Sorry, there was a problem downloading your image!': 'Mae\'n ddrwg gennym, roedd problem wrth lawrlwytho eich delwedd!', // components / modebar / buttons.js: 80
'Preparing image - this may take a few seconds': 'Paratoi\'r ddelwedd - gallai hyn gymryd ychydig o eiliadau', // components / modebar / buttons.js: 62
'Toggle Spike Lines': 'Toglo llinellau pigog', // components / modebar / buttons.js: 559
'Toggle show closest data on hover': 'Toglo dangos y data agosaf wrth hofran', // components / modebar / buttons.js: 364
'Turntable rotation': 'Cylchdroi trofwrdd', // components / modebar / buttons.js: 296
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/de.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ module.exports = {
'Reset view': 'Ansicht zurücksetzen', // components/modebar/buttons.js:583
'Reset views': 'Ansichten zurücksetzen', // components/modebar/buttons.js:529
'Show closest data on hover': 'Zeige näheste Daten beim Überfahren', // components/modebar/buttons.js:157
'Snapshot succeeded': 'Snapshot erfolgreich', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your snapshot!': 'Es gab ein Problem beim Herunterladen des Snapshots', // components/modebar/buttons.js:69
'Taking snapshot - this may take a few seconds': 'Erstelle einen Snapshot - dies kann einige Sekunden dauern', // components/modebar/buttons.js:57
'Image download succeeded': 'Bild-Download erfolgreich', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your image!': 'Es gab ein Problem beim Herunterladen des Bildes', // components/modebar/buttons.js:69
'Preparing image - this may take a few seconds': 'Bild wird vorbereitet - dies kann einige Sekunden dauern', // components/modebar/buttons.js:57
'Zoom': 'Zoom', // components/modebar/buttons.js:85
'Zoom in': 'Hineinzoomen', // components/modebar/buttons.js:121
'Zoom out': 'Herauszoomen', // components/modebar/buttons.js:130
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ module.exports = {
'Reset view': 'Restaurar vista', // components/modebar/buttons.js:582
'Reset views': 'Restaurar vistas', // components/modebar/buttons.js:528
'Show closest data on hover': 'Mostrar el dato más cercano al pasar por encima', // components/modebar/buttons.js:157
'Snapshot succeeded': 'La captura de la instantánea finalizó correctamente', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your snapshot!': '¡La descarga de la instantánea falló!', // components/modebar/buttons.js:69
'Taking snapshot - this may take a few seconds': 'Capturando una instantánea - podría tardar unos segundos', // components/modebar/buttons.js:57
'Image download succeeded': 'La descarga de la imagen finalizó correctamente', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your image!': '¡La descarga de la imagen falló!', // components/modebar/buttons.js:69
'Preparing image - this may take a few seconds': 'Preparando una imagen - podría tardar unos segundos', // components/modebar/buttons.js:57
'Toggle Spike Lines': 'Mostrar/Ocultar Guías', // components/modebar/buttons.js:547
'Toggle show closest data on hover': 'Activar/Desactivar mostrar el dato más cercano al pasar por encima', // components/modebar/buttons.js:352
'Turntable rotation': 'Rotación plana', // components/modebar/buttons.js:288
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/fi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Palauta näkymän oletusasetukset',
'Reset views': 'Palauta näkymien oletusasetukset',
'Show closest data on hover': 'Näytä kursoria lähin data',
'Snapshot succeeded': 'Tilannekuvan ottaminen onnistui',
'Sorry, there was a problem downloading your snapshot!': 'Pahoittelut, tilannekuvan lataaminen epäonnistui!',
'Taking snapshot - this may take a few seconds': 'Otetaan tilannekuvaa - odota hetki',
'Image download succeeded': 'Kuvan lataaminen onnistui',
'Sorry, there was a problem downloading your image!': 'Pahoittelut, kuvan lataaminen epäonnistui!',
'Preparing image - this may take a few seconds': 'Valmistellaan kuvaa - odota hetki',
'Toggle Spike Lines': 'Näytä huiput',
'Toggle show closest data on hover': 'Näytä kursoria lähin data',
'Turntable rotation': 'Tasokierto',
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/fr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ module.exports = {
'Reset view': 'Réinitialiser',
'Reset views': 'Réinitialiser',
'Show closest data on hover': 'Données les plus proches en survol',
'Snapshot succeeded': 'Conversion réussie',
'Sorry, there was a problem downloading your snapshot!': 'Désolé, un problème est survenu lors du téléchargement de votre graphique',
'Taking snapshot - this may take a few seconds': 'Conversion en cours, ceci peut prendre quelques secondes',
'Image download succeeded': 'Téléchargement du graphique réussi',
'Sorry, there was a problem downloading your image!': 'Désolé, un problème est survenu lors du téléchargement de votre graphique',
'Preparing image - this may take a few seconds': 'Conversion en cours, ceci peut prendre quelques secondes',
'Zoom': 'Zoom',
'Zoom in': 'Zoom intérieur',
'Zoom out': 'Zoom extérieur',
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/hr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Resetirajte pogled',
'Reset views': 'Resetirajte poglede',
'Show closest data on hover': 'Prikaži najbliže podatke pri zadržavanju mišem',
'Snapshot succeeded': 'Preuzimanje slike uspješno',
'Sorry, there was a problem downloading your snapshot!': 'Pojavila se greška prilikom preuzimanja slike!',
'Taking snapshot - this may take a few seconds': 'Preuzimanje slike - ovo može potrajati nekoliko sekundi',
'Image download succeeded': 'Preuzimanje slike uspješno',
'Sorry, there was a problem downloading your image!': 'Pojavila se greška prilikom preuzimanja slike!',
'Preparing image - this may take a few seconds': 'Priprema slike - ovo može potrajati nekoliko sekundi',
'Toggle Spike Lines': 'Postavljanje pomoćnih linija',
'Toggle show closest data on hover': 'Postavljanje prikaza najbližih podataka pri zadržavanju mišem',
'Turntable rotation': 'Turntable rotiranje',
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/it.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Reimposta la vista', // components/modebar/buttons.js:583
'Reset views': 'Reimposta le viste', // components/modebar/buttons.js:529
'Show closest data on hover': 'Mostra i dati più vicini al passaggio del mouse', // components/modebar/buttons.js:157
'Snapshot succeeded': 'Screenshot creato con successo', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your snapshot!': 'Si è verificato un errore durante la creazione dello screenshot', // components/modebar/buttons.js:69
'Taking snapshot - this may take a few seconds': 'Creazione screenshot - potrebbe richiedere qualche secondo', // components/modebar/buttons.js:57
'Image download succeeded': 'Immagine scaricata con successo', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your image!': 'Si è verificato un errore durante il download dell\'immagine', // components/modebar/buttons.js:69
'Preparing image - this may take a few seconds': 'Preparazione dell\'immagine - potrebbe richiedere qualche secondo', // components/modebar/buttons.js:57
'Zoom': 'Zoom', // components/modebar/buttons.js:85
'Zoom in': 'Ingrandisci', // components/modebar/buttons.js:121
'Zoom out': 'Riduci', // components/modebar/buttons.js:130
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/ja.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ module.exports = {
'Reset view': 'ビューをリセット', // components/modebar/buttons.js:583
'Reset views': 'ビューをリセット', // components/modebar/buttons.js:529
'Show closest data on hover': 'ホバー時に一番近いデータを表示', // components/modebar/buttons.js:157
'Snapshot succeeded': 'スナップショットに成功', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your snapshot!': 'すみません、スナップショットダウンロードでエラーです!', // components/modebar/buttons.js:69
'Taking snapshot - this may take a few seconds': 'スナップショットを撮影', // components/modebar/buttons.js:57
'Image download succeeded': '画像のダウンロードに成功', // components/modebar/buttons.js:66
'Sorry, there was a problem downloading your image!': 'すみません、画像のダウンロードでエラーです!', // components/modebar/buttons.js:69
'Preparing image - this may take a few seconds': '画像を準備中', // components/modebar/buttons.js:57
'Zoom': 'ズーム', // components/modebar/buttons.js:85
'Zoom in': '拡大', // components/modebar/buttons.js:121
'Zoom out': '縮小', // components/modebar/buttons.js:130
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/ko.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'view 초기화',
'Reset views': 'views 초기화',
'Show closest data on hover': '마우스를 올리면 근접한 데이터를 보이기',
'Snapshot succeeded': 'Snapshot 성공',
'Sorry, there was a problem downloading your snapshot!': '죄송합니다, snapshot을 다운로드 중 문제가 발생했습니다!',
'Taking snapshot - this may take a few seconds': 'snapshot 찍기 - 수 초가 걸릴 수 있습니다',
'Image download succeeded': '이미지 다운로드 성공',
'Sorry, there was a problem downloading your image!': '죄송합니다, 이미지를 다운로드 중 문제가 발생했습니다!',
'Preparing image - this may take a few seconds': '이미지 준비 - 수 초가 걸릴 수 있습니다',
'Toggle Spike Lines': '스위치로 Lines을 고정합니다',
'Toggle show closest data on hover': '스위치로 마우스를 올렸을 때 가장 가까운 데이터를 보여줍니다',
'Turntable rotation': 'Turntable 회전',
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/no.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Nullstille visning', // components/modebar/buttons.js:512
'Reset views': 'Nullstille visninger', // components/modebar/buttons.js:550
'Show closest data on hover': 'Vis nærmeste verdi når musepekeren holdes over', // components/modebar/buttons.js:166
'Snapshot succeeded': 'Bilde Laget', // components/modebar/buttons.js:75
'Sorry, there was a problem downloading your snapshot!': 'Beklager, noe gikk galt under nedlasting av bildet', // components/modebar/buttons.js:78
'Taking snapshot - this may take a few seconds': 'Oppretter bilde - dette kan ta noen sekunder', // components/modebar/buttons.js:60
'Image download succeeded': 'Bilde lastet ned', // components/modebar/buttons.js:75
'Sorry, there was a problem downloading your image!': 'Beklager, noe gikk galt under nedlasting av bildet', // components/modebar/buttons.js:78
'Preparing image - this may take a few seconds': 'Forbereder bilde - dette kan ta noen sekunder', // components/modebar/buttons.js:60
'Toggle Spike Lines': 'Aktiver / deaktiver topplinjer', // components/modebar/buttons.js:569
'Toggle show closest data on hover': 'Aktiver / deaktiver nærmeste verdi når musepekeren holdes over', // components/modebar/buttons.js:361
'Turntable rotation': 'Flat rotation', // components/modebar/buttons.js:290
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/pt-br.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Restaurar visão',
'Reset views': 'Restaurar visões',
'Show closest data on hover': 'Exibir dado mais próximo ao pairar',
'Snapshot succeeded': 'Captura instantânea completa',
'Sorry, there was a problem downloading your snapshot!': 'Desculpe, houve um problema no download de sua captura instantânea!',
'Taking snapshot - this may take a few seconds': 'Efetuando captura instantânea - isso pode levar alguns instantes',
'Image download succeeded': 'Download da imagem concluído com sucesso',
'Sorry, there was a problem downloading your image!': 'Desculpe, houve um problema no download de sua imagem!',
'Preparing image - this may take a few seconds': 'Preparando a imagem - isso pode levar alguns instantes',
'Toggle Spike Lines': 'Habilitar/desabilitar triangulação de linhas',
'Toggle show closest data on hover': 'Habilitar/desabilitar exibição de dado mais próximo ao pairar',
'Turntable rotation': 'Rotação de mesa',
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/pt-pt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ module.exports = {
'Reset view': 'Restaurar vista',
'Reset views': 'Restaurar vistas',
'Show closest data on hover': 'Exibir dado mais próximo ao pairar',
'Snapshot succeeded': 'Captura instantânea com sucesso',
'Sorry, there was a problem downloading your snapshot!': 'Desculpe, houve um problema no download de sua captura instantânea!',
'Taking snapshot - this may take a few seconds': 'Efetuando captura instantânea - isso pode demorar alguns segundos',
'Image download succeeded': 'Download da imagem concluído com sucesso',
'Sorry, there was a problem downloading your image!': 'Desculpe, houve um problema no download da sua imagem!',
'Preparing image - this may take a few seconds': 'A preparar a imagem - isso pode demorar alguns segundos',
'Toggle Spike Lines': 'Habilitar/desabilitar triangulação de linhas',
'Toggle show closest data on hover': 'Habilitar/desabilitar exibição de dado mais próximo ao pairar',
'Turntable rotation': 'Rodar',
Expand Down
6 changes: 3 additions & 3 deletions lib/locales/ro.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ module.exports = {
'Reset view': 'Resetează vizualizarea',
'Reset views': 'Resetează vizualizările',
'Show closest data on hover': 'Afișează cele mai apropiate date la trecerea cu mouse-ul',
'Snapshot succeeded': 'Crearea capturii de ecran a reușit',
'Sorry, there was a problem downloading your snapshot!': 'Ne pare rău, a apărut o eroare la descărcarea capturii de ecran!',
'Taking snapshot - this may take a few seconds': 'Se crează captura de ecran - poate dura câteva secunde',
'Image download succeeded': 'Descărcarea imaginii a reușit',
'Sorry, there was a problem downloading your image!': 'Ne pare rău, a apărut o eroare la descărcarea imaginii!',
'Preparing image - this may take a few seconds': 'Se pregătește imaginea - poate dura câteva secunde',
'Toggle Spike Lines': 'Comutarea afișării liniilor de vârf',
'Toggle show closest data on hover': 'Comutarea afișării celor mai apropiate date',
'Turntable rotation': 'Rotație pe axă',
Expand Down
Loading
Loading