Repository navigation
Conversation
When the caller exports SHELLOPTS, cronic's `set -u` was inherited by the wrapped command, so a bash script that it ran (such as texi2dvi, via `makeinfo --pdf`, where /bin/sh is bash) failed on an unset variable.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ing errexit Save the caller's options with `set +o` and restore them in a subshell that runs the wrapped command. Document the limitation for builtins such as `source` and `eval`. Use one test wrapper script instead of two.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the caller exports
SHELLOPTS, cronic'sset -uwas inherited by the wrapped command. A bash script that the command runs then failed on its first unset variable. For example, Daikon's Rocky Linux CI fails incronic makeinfo --pdfwith:(
texi2dviis a#!/bin/shscript, and/bin/shis bash on Rocky Linux.)Now cronic records whether the caller had
nounsetset, and runs the wrapped command with the caller's setting. The new tests intests/cronic-test/cronic-test.shcover callers that exportSHELLOPTSwith and withoutset -u.