Skip to content

cronic: run the command in a subshell, so that exit or exec cannot prevent the report - #140

Merged
mernst merged 1 commit into
plume-lib:masterfrom
mernst:cronic-subshell
Oct 10, 2026
Merged

mernst merged 1 commit into
plume-lib:masterfrom
mernst:cronic-subshell

Conversation

@mernst

@mernst mernst commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

When the wrapped command was a builtin such as exit or exec, it ended cronic itself, so cronic printed no report. cronic now runs the command in a subshell.

Split from #135.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: plume-lib/plume-scripts/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b7761be1-b86d-4d34-95b0-ee27e06b89be

📥 Commits

Reviewing files that changed from the base of the PR and between b5ec97e and b177e20.


📒 Files selected for processing (2)
  • cronic
  • tests/cronic-test/cronic-test.sh

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst
mernst merged commit bbbcd9c into plume-lib:master Oct 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant