Repository navigation
Make cronic portable to macOS's BSD grep and cmp, and test it on macOS - #141
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to The macOS test job follows the repository’s workflow requirements. No actionable merge-blocking issue remains from this review. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
-
🛠️ Fix failing CI checks 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
# Conflicts: # cronic
… behavior, and detect BASH_XTRACEFD by feature Accept GNU make 3.81's `dir' quoting and the name gmake in cronic's make filter; state precisely which utilities cronic uses portably. In the tests, check cronic's behavior under a bash earlier than 4.1 instead of skipping it, run a real bash trace nested 3 deep through the stderr path, and test /bin/bash for BASH_XTRACEFD support rather than copying cronic's version test.
…more thoroughly Simplify cronic's trace pattern and stderr filter. Run the trace-and-stderr check on every bash, run the PS4-dependent old-bash checks only when not root, make temp-file-test search through macOS's /tmp symlink, and put /bin first in PATH in the macOS CI job so that it tests bash 3.2.
…s, and make the BASH_XTRACEFD probe ignore warnings
…he trace file in one pass
…not repeat unfiltered stderr
…nto cronic-portability # Conflicts: # cronic # tests/cronic-test/cronic-test.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request builds on #139; merge #139 first. Until then, this pull request's diff also shows #139's commits.
\+,\?, and\|with POSIX equivalents (a repeated group for the PS4 pattern, andgrep -Efor themakedirectory filter), and usecmp -srather thancmp --silent.cronic-test.sh, skip the two "silent" checks for a PS4 that contains an expansion or an escape when/bin/bashis earlier than 4.1. WithoutBASH_XTRACEFD, such trace lines go to stderr and cannot be recognized; these two checks already failed under bash 3.2.cronictests onmacos-latest, whose/bin/bashis bash 3.2 and whose utilities are BSD.Tested locally on Linux, and in the
bash:3.2Docker image (busyboxgrepandcmp) as a non-root user.