Skip to content

fix: Detect modern Edge instead of reporting it as Chrome. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pocketarc merged 4 commits into from
Jul 18, 2026
+22 −2
Merged

fix: Detect modern Edge instead of reporting it as Chrome. #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c9f91a
Update Edge user agent detection for legacy version
livenobin Apr 2, 2026
23ba747
Merge PR #45: modern Edge user-agent detection from @livenobin.
pocketarc Jul 18, 2026
993f4a6
fix: Match legacy Edge before Chromium Edge.
pocketarc Jul 18, 2026
083dda7
Merge remote-tracking branch 'origin/develop' into fix-edge-user-agent
pocketarc Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions application/config/user_agents.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@
$browsers = array(
'OPR' => 'Opera',
'Flock' => 'Flock',
'Edg' => 'Edge',
'Edge' => 'Edge Legacy',
'Edge' => 'Edge Legacy',
'Edg' => 'Edge',
'Chrome' => 'Chrome',
// Opera 10+ always reports Opera/9.80 and appends Version/<real version> to the user agent string
'Opera.*?Version' => 'Opera',
Expand Down
20 changes: 20 additions & 0 deletions tests/codeigniter/libraries/Useragent_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,24 @@ public function test_parse()
$this->assertTrue($this->agent->is_mobile('android'));
}

public function test_edge()
{
// Chromium Edge's UA also contains "Chrome/", so without an "Edg" match
// it's detected as Chrome.
$this->agent->parse('Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36 Edg/91.0.864.59');
$this->assertEquals('Edge', $this->agent->browser());
$this->assertEquals('91.0.864.59', $this->agent->version());

// Legacy Edge sends "Edge/", which contains "Edg", so it must not be
// caught by the Chromium "Edg" rule.
$this->agent->parse('Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/18.18363');
$this->assertEquals('Edge Legacy', $this->agent->browser());
$this->assertEquals('18.18363', $this->agent->version());

// Mobile Edge tokens ("EdgA" on Android, "EdgiOS" on iOS) omit the "e",
// so only the "Edg" rule can catch them.
$this->agent->parse('Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Mobile Safari/537.36 EdgA/120.0.0.0');
$this->assertEquals('Edge', $this->agent->browser());
}

}
Loading