Repository navigation
feat!: Use AFS common and scientific names in freshwaterfish - #56
Merged
Merged
Conversation
Rename ten common names and correct eleven scientific names to match Page et al. (2023), Common and Scientific Names of Fishes from the United States, Canada, and Mexico, 8th edition. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
joethorley
marked this pull request as ready for review
November 10, 2026 17:28
sarahLy9
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Aligns
freshwaterfishwith the American Fisheries Society list (Page et al. 2023, 8th edition, doi:10.47886/9781934874691).Only
data-raw/freshwaterfish/freshwaterfish.csvwas edited;data/freshwaterfish.rdaand the test snapshot were rebuilt from it.The snapshot diff is large because the renamed genera change the row order and column widths.
Marked breaking because
fbc_common_name()now returns different names for ten codes.Common names
Scientific names
Species2cyclindraceumSpecies2cylindraceumNot changed, for the maintainer to decide
MSUNorthern Mountain Sucker (Catostomus platyrhynchus): AFS lists Mountain Sucker (Pantosteus platyrhynchus) for the United States only and assigns Canadian populations to Cordilleran Sucker (P. bondi) and Plains Sucker (P. jordani).CT,ACT,CCT,WCT: AFS treats Coastal Cutthroat Trout (Oncorhynchus clarkii) and Westslope Cutthroat Trout (O. lewisi) as separate species, so "Cutthroat Trout" is no longer a species name.GTGolden Trout: AFS uses Oncorhynchus aguabonita, not a subspecies of O. mykiss.RSMRainbow Smelt (Osmerus dentex,Species2mordax): AFS calls O. dentex Pacific Rainbow Smelt and O. mordax Rainbow Smelt.PDCNorthern Pearl Dace (Margariscus margarita,Species2nachtriebi): AFS uses Margariscus nachtriebi.ALArctic Lamprey (Lampetra sp): AFS uses Lethenteron camtschaticum.Class,Order, andFamily: not compared with the AFS classification (for example AFS now places most North American minnows in Leuciscidae).Tests pass and
R CMD checkis clean locally.🤖 Generated with Claude Code