Skip to content

feat!: Use AFS common and scientific names in freshwaterfish - #56

Merged
joethorley merged 1 commit into
mainfrom
afs-names
Nov 10, 2026
Merged

joethorley merged 1 commit into
mainfrom
afs-names

Conversation

@joethorley

Copy link
Copy Markdown
Member

Closes #55

Aligns freshwaterfish with the American Fisheries Society list (Page et al. 2023, 8th edition, doi:10.47886/9781934874691).
Only data-raw/freshwaterfish/freshwaterfish.csv was edited; data/freshwaterfish.rda and the test snapshot were rebuilt from it.
The snapshot diff is large because the renamed genera change the row order and column widths.

Marked breaking because fbc_common_name() now returns different names for ten codes.

Common names

Code Old New
CAL Coastrange Sculpin (formerly Aleutian Sculpin) Coastrange Sculpin
CLA Staghorn Sculpin Pacific Staghorn Sculpin
CMM Malheur Mottled Sculpin Malheur Sculpin
CP Carp Common Carp
GAM Mosquitofish Western Mosquitofish
LL Cowichan Lake Lamprey Vancouver Lamprey
OWF Oriental Weatherfish Pond Loach
PCC Peamouth Chub Peamouth
RL River Lamprey Western River Lamprey
TP Trout-Perch Trout-perch

Scientific names

Code Old New
BSU Catostomus columbianus Pantosteus columbianus
CBA Cottus bairdi Cottus bairdii
CMC Acrocheilus alutaceus Gila alutacea
CMT Myoxocephalus thompsoni Myoxocephalus thompsonii
LL Lampetra macrostoma Entosphenus macrostoma
LMB Micropterus salmoides Micropterus nigricans
PL Lampetra tridentata Entosphenus tridentatus
PLS Spirincus sp. 1 Spirinchus sp. 1
RW Prosopium cyclindraceum Prosopium cylindraceum
SMB Micropterus dolomieui Micropterus dolomieu
STC Notropis hudsonius Hudsonius hudsonius
MWxRW Species2 cyclindraceum Species2 cylindraceum

Not changed, for the maintainer to decide

  • MSU Northern Mountain Sucker (Catostomus platyrhynchus): AFS lists Mountain Sucker (Pantosteus platyrhynchus) for the United States only and assigns Canadian populations to Cordilleran Sucker (P. bondi) and Plains Sucker (P. jordani).
  • CT, ACT, CCT, WCT: AFS treats Coastal Cutthroat Trout (Oncorhynchus clarkii) and Westslope Cutthroat Trout (O. lewisi) as separate species, so "Cutthroat Trout" is no longer a species name.
  • GT Golden Trout: AFS uses Oncorhynchus aguabonita, not a subspecies of O. mykiss.
  • RSM Rainbow Smelt (Osmerus dentex, Species2 mordax): AFS calls O. dentex Pacific Rainbow Smelt and O. mordax Rainbow Smelt.
  • PDC Northern Pearl Dace (Margariscus margarita, Species2 nachtriebi): AFS uses Margariscus nachtriebi.
  • AL Arctic Lamprey (Lampetra sp): AFS uses Lethenteron camtschaticum.
  • Class, Order, and Family: not compared with the AFS classification (for example AFS now places most North American minnows in Leuciscidae).
  • Hybrids (Splake, Tiger Muskellunge): AFS does not capitalize hybrid names.

Tests pass and R CMD check is clean locally.

🤖 Generated with Claude Code

Rename ten common names and correct eleven scientific names to match
Page et al. (2023), Common and Scientific Names of Fishes from the United
States, Canada, and Mexico, 8th edition.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@joethorley
joethorley marked this pull request as ready for review November 10, 2026 17:28
@joethorley
joethorley requested a review from sarahLy9 as a code owner November 10, 2026 17:28
@joethorley
joethorley merged commit bd26250 into main Nov 10, 2026
11 checks passed
@joethorley
joethorley deleted the afs-names branch November 10, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align freshwaterfish names with the AFS list

2 participants