Repository navigation
fix: same-named tables in different schemas mixed in one Iceberg table - #92
Merged
Merged
Conversation
With sink.namespace set, every table's Iceberg namespace replaces its PG schema, so public.orders and sales.orders both materialized into <namespace>.orders: one table holding both tables' rows, each overwriting the other's on shared keys. Nothing checked for it. Config loading now refuses two tables that map to one Iceberg table (and a table listed twice), so every subcommand fails fast with a pointer to sink.namespace. TableConfig::iceberg_ident is the one definition of the mapping, replacing three copies in setup.rs and run.rs. The DST's sink.namespace dimension now replicates sales.returns as public.returns, still exercising the PG → Iceberg name translation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
same_named_tables_under_one_sink_namespace_stay_apart.With
sink.namespaceset, each table's Iceberg namespace replaces its PG schema.public.ordersandsales.orderstherefore both materialized into<namespace>.orders: one Iceberg table holding both tables' rows, where rows sharing a key overwrite each other. Nothing checked for it.