Repository navigation
fix(streaming): keep the text of a chunk that has an empty reasoning field - #483
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
…field Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAICompletionsProvider.stream_content()checkedreasoning is not None. A chunk that carries text together with an emptyreasoning/reasoning_contentfield ("") therefore returnedContentThinkingDelta("")and the chunk's text was never returned. Streaming from an OpenAI-compatible server that sends an empty reasoning field on every chunk lost the streamed text.The check is now
if reasoning:, so an empty reasoning field falls through to the text. A chunk with only an empty reasoning field still adds nothing. This is the shared stream path for the providers built onOpenAICompletionsProvider.Test:
test_stream_content_empty_reasoning_keeps_textbuilds realChatCompletionChunks (no network) and fails on main, passes here. CHANGELOG entry added; no issue number yet.This change was made with Claude Code.
🤖 Generated with Claude Code
🤖 Generated with Claude Code