Add configurable Postgres replication socket timeout#715
Open
sravan27 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 7b6e7df The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional Postgres
replication_socket_timeoutsetting that applies only to logical replication connections.This is a narrow follow-up to #700. The issue discussion established that half-open source connections can leave replication stalled for 12-16 minutes before the OS/TCP path surfaces an error.
@powersync/service-jpgwirealready destroys sockets on timeout and the replication job already reconnects whenWalStream.replicate()throws, but the Postgres replication connection had no per-stream override comparable to the existing snapshot timeout.With this change, self-hosted operators can choose a shorter timeout for the replication socket so a half-open stream is destroyed earlier and the existing retry path can reconnect.
Details
replication_socket_timeoutto the Postgres data source config.PgManager.replicationConnection().Example:
Tests
pnpm --filter @powersync/service-module-postgres buildpnpm --filter @powersync/service-module-postgres build:testspnpm exec vitest run test/src/config.test.tsfrommodules/module-postgresScope
This does not attempt to solve every option discussed in #700. In particular, it does not add
TCP_USER_TIMEOUT,TCP_KEEPINTVL,TCP_KEEPCNT, or a new replication-progress health model. It is a small operational knob that lets affected deployments reduce the current detection window using the socket-timeout behavior already present inservice-jpgwire.