Skip to content

Mooncake transfer engine rocm build script - #8827

Open
Daniel-Schenker wants to merge 9 commits into
ppc64le:masterfrom
Daniel-Schenker:mooncake-transfer-engine-rocm-build-script
Open

Daniel-Schenker wants to merge 9 commits into
ppc64le:masterfrom
Daniel-Schenker:mooncake-transfer-engine-rocm-build-script

Conversation

@Daniel-Schenker

Copy link
Copy Markdown
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container (UBI 10)
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@cdeepali

Copy link
Copy Markdown
Contributor

@Daniel-Schenker pls add License file under the m/mooncake-transfer-engine-rocm directory.

"docker_build": false,
"validate_build_script": true,
"use_non_root_user": false,
"wheel_name": "mooncake-transfer-engine-rocm",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"wheel_name": "mooncake-transfer-engine-rocm",
"wheel_name": "mooncake-transfer-engine",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdeepali Upstream vLLM requirements specifically ask for package name of "mooncake-transfer-engine-rocm"

See here: https://github.com/vllm-project/vllm/blob/db9527a46873454610df6dbedf79a36d6bf1a7f6/requirements/rocm.txt#L31

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants