Skip to content

graduate primer_react_theme_provider_remove_ssr_handoff ff#8057

Open
francinelucca wants to merge 3 commits into
mainfrom
chore/graduate-theming-ff
Open

graduate primer_react_theme_provider_remove_ssr_handoff ff#8057
francinelucca wants to merge 3 commits into
mainfrom
chore/graduate-theming-ff

Conversation

@francinelucca

Copy link
Copy Markdown
Member

Changelog

Removed

  • primer_react_theme_provider_remove_ssr_handoff and related code

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings June 25, 2026 04:08
@francinelucca francinelucca requested a review from a team as a code owner June 25, 2026 04:08
@francinelucca francinelucca requested a review from joshblack June 25, 2026 04:08
@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fda08a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Jun 25, 2026
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the primer_react_theme_provider_remove_ssr_handoff feature flag and associated SSR handoff/script logic from ThemeProvider, simplifying how resolvedColorMode is determined and making preventSSRMismatch a deprecated no-op.

Changes:

  • Removed SSR handoff cache + <script type="application/json"> injection and feature-flag gating from ThemeProvider.
  • Deprecated preventSSRMismatch (now has no effect) and removed related unit tests.
  • Removed the graduated feature flag from DefaultFeatureFlags.
Show a summary per file
File Description
packages/react/src/ThemeProvider.tsx Removes SSR handoff/script logic and feature-flag checks; deprecates preventSSRMismatch as a no-op.
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Deletes the graduated primer_react_theme_provider_remove_ssr_handoff default flag entry.
packages/react/src/tests/ThemeProvider.test.tsx Removes tests and imports related to SSR handoff/script rendering and the feature flag.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Comment thread packages/react/src/ThemeProvider.tsx
Comment thread packages/react/src/ThemeProvider.tsx
@github-actions github-actions Bot requested a deployment to storybook-preview-8057 June 25, 2026 04:15 Abandoned
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
@primer-integration

primer-integration Bot commented Jun 25, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Waiting  CI   Waiting
Passed  VRT   Passed
Waiting  Projects   Waiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Canary Release Apply this label when you want CI to create a canary release of the current PR integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants