Skip to content

fix(build): use double quotes for skills wildcard in prepare script - #30227

Open
AbhilashG12 wants to merge 3 commits into
prisma:mainfrom
AbhilashG12:fix/windows-prepare-script
Open

fix(build): use double quotes for skills wildcard in prepare script#30227
AbhilashG12 wants to merge 3 commits into
prisma:mainfrom
AbhilashG12:fix/windows-prepare-script

Conversation

@AbhilashG12

@AbhilashG12 AbhilashG12 commented Sep 8, 2026

Copy link
Copy Markdown

Linked issue

n/a — small change

Summary

Windows cmd.exe does not strip single quotes around arguments. This caused the prepare script to pass literal '*' to the skills CLI on Windows, crashing the pnpm install process. Escaping double quotes (\"*\") is cross-platform and fixes the setup process for Windows contributors.

Testing performed

  • Manual: Ran pnpm run prepare successfully on a Windows environment.
  • pnpm typecheck && pnpm lint && pnpm test:packages

Skill update

n/a — internal only

Checklist

  • I read CONTRIBUTING.md and the change is scoped to one logical concern.
  • All commits are signed off (git commit -s) per the DCO. The DCO status check will block merge if any commit is missing a Signed-off-by: trailer.
  • Tests are updated (or n/a if the change is doc-only / refactor with no behavioural delta).
  • The PR title is in TML-NNNN: <sentence-case title> form (Linear ticket prefix + concise title naming the concrete deliverable). See .claude/skills/create-pr/SKILL.md for the full convention. (Note: I used the conventional commit format fix(build): ... as requested in CONTRIBUTING.md, since I do not have an internal Linear ticket).
  • The Skill update section above is filled in (or stated n/a — internal only).

Notes for the reviewer

Hit this issue immediately upon cloning and running pnpm install on Windows. Submitting this small patch to help future Windows contributors get started without bypassing lifecycle scripts.

Summary by CodeRabbit

  • Chores
    • Updated the setup command’s wildcard argument quoting; behavior remains unchanged.

…o support Windows

Signed-off-by: AbhilashG12 <abhilashggg15@gmail.com>
@AbhilashG12
AbhilashG12 requested a review from a team as a code owner September 8, 2026 04:03
@CLAassistant

CLAassistant commented Sep 8, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: 064656a5-ccbc-416c-9e6c-95767636c89e

📥 Commits

Reviewing files that changed from the base of the PR and between 10081bc and 3171cc6.

📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The prepare script now uses double quotes around the * argument passed to skills add. The command otherwise remains unchanged.

Changes

Prepare script update

Layer / File(s) Summary
Quote the skill wildcard argument
package.json
The prepare script changes the --skill "*" argument from single quotes to double quotes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5b094

The prepare command now passes the skills wildcard correctly on Windows while preserving its intended argument behavior elsewhere. No current merge-blocking risk remains.

Suggested reviewers: wmadden-electric

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: using double quotes for the skills wildcard in the prepare script to fix the build issue.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants