fix(build): use double quotes for skills wildcard in prepare script - #30227
fix(build): use double quotes for skills wildcard in prepare script#30227AbhilashG12 wants to merge 3 commits into
Conversation
…o support Windows Signed-off-by: AbhilashG12 <abhilashggg15@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe ChangesPrepare script update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The prepare command now passes the skills wildcard correctly on Windows while preserving its intended argument behavior elsewhere. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Linked issue
n/a — small change
Summary
Windows
cmd.exedoes not strip single quotes around arguments. This caused thepreparescript to pass literal'*'to the skills CLI on Windows, crashing thepnpm installprocess. Escaping double quotes (\"*\") is cross-platform and fixes the setup process for Windows contributors.Testing performed
pnpm run preparesuccessfully on a Windows environment.pnpm typecheck && pnpm lint && pnpm test:packagesSkill update
n/a — internal only
Checklist
git commit -s) per the DCO. The DCO status check will block merge if any commit is missing aSigned-off-by:trailer.n/aif the change is doc-only / refactor with no behavioural delta).TML-NNNN: <sentence-case title>form (Linear ticket prefix + concise title naming the concrete deliverable). See.claude/skills/create-pr/SKILL.mdfor the full convention. (Note: I used the conventional commit formatfix(build): ...as requested in CONTRIBUTING.md, since I do not have an internal Linear ticket).n/a — internal only).Notes for the reviewer
Hit this issue immediately upon cloning and running
pnpm installon Windows. Submitting this small patch to help future Windows contributors get started without bypassing lifecycle scripts.Summary by CodeRabbit