Repository navigation
fix: only report window errors thrown by processout.js - #282
Merged
Merged
Conversation
roshan-gorasia-cko
requested review from
jakubjasinsky
and
a balanced review from Copilot
October 19, 2026 13:15
roshan-gorasia-cko
marked this pull request as ready for review
October 19, 2026 13:15
The global error handler reported any error whose file was on a ProcessOut host. Some browsers attribute errors from their injected scripts to the page URL, so errors that aren't ours were reported. Restrict reporting to the processout.js script and skip events with no error object. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
roshan-gorasia-cko
force-pushed
the
fix/telemetry-own-script-errors
branch
from
October 19, 2026 13:16
68e240d to
33d1b71
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes address the reported telemetry noise with targeted tests and no identified blocking issues.
No open issues 🎉
What changed in this PR
Restricts global error telemetry to processout.js errors on ProcessOut hosts, excluding browser-injected errors attributed to hosted payment pages.
Changes:
- Adds a script URL filter that skips events without an error object.
- Adds targeted filter tests and a telemetry test loader.
- Bumps the version to 1.9.16.
| File | Description |
|---|---|
| test/support/loadNamespace.ts | Adds a telemetry namespace loader for tests. |
| test/processout/telemetry.test.ts | Tests accepted URLs and rejected error events. |
| src/processout/telemetry.ts | Defines the script error filter. |
| src/processout/processout.ts | Applies the filter to global error reporting. |
| package.json | Bumps the version to 1.9.16. |
Review effort: Balanced
tomasz-pazdziurek-cko
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The global error handler reported any error whose file was on a ProcessOut host. Some browsers, such as Chrome on iOS, attribute errors from their own injected scripts to the page URL, so errors that aren't ours were being reported.
Solution
processout.jsscript itself (isProcessOutScriptErrorintelemetry.ts).errorobject, which the handler previously dereferenced.Checklist
yarn bump-versionNotes
Unit tests cover the filter in
test/processout/telemetry.test.ts.🤖 Generated with Claude Code